1889383 - "Item changed on server" dialog (calendar-conflicts-dialog) needs a scrollbar

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Tristan Miller]

Attachment: An excessively large "Item changed on server" dialog

When Lightning produces an "Item changed on server" dialog for an event, it reproduces the entire description of that event. If that description contains many lines of text, then Lightning naïvely increases the height of the dialog to accommodate them. This can result in the dialog exceeding the height of the screen, as the attached screenshot shows. This makes it impossible to read the entire event description, and also cuts off the "Discard my changes and reload" and "Submit my changes anyway" buttons at the bottom of the dialog.

The dialog should put the event description in a frame with scrollbars.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1889383 - "Item changed on server" dialog (calendar-conflicts-dialog) needs a scrollbar. r=freaktechnik

For testing:

window.openDialog(
  "chrome://calendar/content/calendar-conflicts-dialog.xhtml",
  "calendarConflictsDialog",
  "chrome,titlebar,modal",
  {
  item: { isEvent() { return true}, getProperty() { return "ABC"; }, get calendar() { return { name: "test"} }, title: "Test title", descriptionText: "ABCABCBABA ".repeat(1000) } ,
  mode: "modify",
  overwrite: false,
  }
);

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/22df40bf8803
"Item changed on server" dialog (calendar-conflicts-dialog) needs a scrollbar. r=freaktechnik

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9395238 [details]
Bug 1889383 - "Item changed on server" dialog (calendar-conflicts-dialog) needs a scrollbar. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): unclear
User impact if declined: may not be able to see full content
Testing completed (on c-c, etc.): c-c, beta (once 126beta shipped)
Risk to taking this patch (and alternatives if risky): safe

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9395238 [details]
Bug 1889383 - "Item changed on server" dialog (calendar-conflicts-dialog) needs a scrollbar. r=freaktechnik

[Triage Comment]
We will let this ride the train to 128

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9395238 [details]
Bug 1889383 - "Item changed on server" dialog (calendar-conflicts-dialog) needs a scrollbar. r=freaktechnik

[Triage Comment]
correcting accident