1889600 - Glitches on the address bar when hovering over tabs or loading new tabs with system dark theme

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: System default theme glitch.mov

Found in

• 126.0a1 (2024-04-04)

Affected versions

• 126.0a1 (2024-04-04)

Tested platforms

• Affected platforms: macOS 12, macOS 14, macOS 13
• Unaffected platforms: Windows 10x64

Preconditions

• system theme set to dark
• Firefox theme set to System theme

Steps to reproduce

1. Open some random tabs with random webpages
2. Hover over tabs.

Expected result

• No glitches are displayed.

Actual result

• Glitches are displayed on the address bar.

Regression range

• Mozregression pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b32ac7e3920bb4989f63b8f6b6e8cf8803cb9876&tochange=9f62b9886f80f5d348626e33731dd5a96856638e

I am not sure which or if the pushlog is accurate due to the intermittency, please let me know if another regression range is needed.

Additional notes

• Attached a screen recording.
• Issue is intermittent.

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Nicolas, could you please take a look to see if the above patches might have caused this issue? Thank you in advance!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #0, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:nical and :jcristau, since you are the authors of the changes in the range, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox126 (nightly). We have limited time to fix this, the soft freeze is in 7 days. However, the bug still isn't assigned.

:bhood, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 4

[Alice0775 White]

I can reproduce this issue on Nightly126.0a1 Windows11 with theme[1].

[1] addons.mozilla.org/en-US/firefox/addon/classicpink/ .

See screencast: https://youtu.be/RVq5xQySZuE

Comment 6

[erosman]

I am also experiencing the same on light theme, Ubuntu 23.10 Wayland.

Comment 7

[erosman]

Attachment: Address-bar issue

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 1889600 - Don't produce commands if all of the quad segments are discarded. r=#gfx-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e46f0595d1cf
Don't produce commands if all of the quad segments are discarded. r=emilio

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e46f0595d1cf

Comment 15

[Natalia Csoregi [:nataliaCs]]

Backed out 6 changesets (bug 1889600, bug 1885571, bug 1888400, bug 1887837) for causing multiple regressions.

• backout: https://hg.mozilla.org/integration/autoland/rev/b79722547ccb00704f8a180b7910b8b3c6805f4e

Comment 16

[Donal Meehan [:dmeehan]]

Resolving as fixed by backing out the regressor
https://bugzilla.mozilla.org/show_bug.cgi?id=1888400#c9

Comment 17

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 126.0a1 (2024-04-07) on Windows 11, Windows 10x64, macOS 12, macOS 14 and Ubuntu 23.10. There are no glitches in the address bar after following the steps from comment 0 on macOS 12 and 14, steps from comment 4 on Windows 11x64, and steps from comment 6 on Ubuntu 23.10. I have also tested hovering over the Slack sidebar and bug 1889705 test case and the issues are not reproducible anymore.