1887837 - Port conic gradients to the quad shaders

Status: REOPENED

(Core :: Graphics: WebRender, task)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1887837 - Conic gradient quad shader (initially disabled). r=gw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b15f6d439444
Conic gradient quad shader. r=gw

Comment 3

[Iulian Moraru]

Backed out for causing reftest failures on radial-size-1a.html.

• Push with failures

• Failure log

• Backout link

LATER EDIT: some Wrench build bustages appeared later. So far, they only happened on Android 11.0 Samsung A51 Arm7 opt and debug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/730836e9a9e4
Conic gradient quad shader. r=gw

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/730836e9a9e4

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out 6 changesets (bug 1889600, bug 1885571, bug 1888400, bug 1887837) for causing multiple regressions.

• backout: https://hg.mozilla.org/integration/autoland/rev/b79722547ccb00704f8a180b7910b8b3c6805f4e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4112523a0a44
Conic gradient quad shader (initially disabled). r=gw

Comment 8

[Aron Cseh]

• Backout link
• Push with failures
• Failure Log
• Failure Log 2

[task 2024-04-23T08:57:24.036Z] 08:57:24    ERROR -  error: unused variable: `data_handle`
[task 2024-04-23T08:57:24.036Z] 08:57:24     INFO -     --> gfx/wr/webrender/src/prepare.rs:233:52
[task 2024-04-23T08:57:24.036Z] 08:57:24     INFO -      |
[task 2024-04-23T08:57:24.037Z] 08:57:24     INFO -  233 |             PrimitiveInstanceKind::ConicGradient { data_handle, .. } => {

Comment 9

[Nicolas Silva [:nical]]

Attachment: Bug 1887837 - Enable quad conic gradients. r=gw

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fb65ee4782b
Conic gradient quad shader (initially disabled). r=gw

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7fb65ee4782b

Comment 12

[Nicolas Silva [:nical]]

Attachment: Bug 1887837 - Enable quad conic gradients when the GPU is used. r=gw

Conic gradients are too slow on swgl, we have to add support for caching them. Meanwhile, enable the code path when swgl is disabled.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb5eb6f5972f
Enable quad conic gradients when the GPU is used. r=gw

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/eb5eb6f5972f