1889769 - Firefox View tab row buttons are no longer flush right within card containers

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Kelly Cochrane [:kcochrane]]

As part of the fxview-tab-list/row refactor in bug 1880542, the grid alignment for tab rows other than open tabs tab rows seems off, specifically the buttons are no longer flush with the right of the card's inner padding. We should adjust the styles there so that each tab row spans the full width of the card up to the card's inner padding.

This is happening for all tab rows EXCEPT Open Tabs tab rows (so Recently Closed Tabs, Synced Tabs, History).

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Screenshot 2024-04-04 at 1.55.23 PM.png

See the attached screenshot where the Open Tabs tab rows are spanning the full width as expected, but Recently closed tabs tab rows are not.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1889769 - Fix alignment of tab rows in Firefox View

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1880542

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b015e423be91
Fix alignment of tab rows in Firefox View r=fxview-reviewers,nsharpley

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b015e423be91

Comment 6

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: "x" button is not right aligned

I was able to replicate the issue on an affected Firefox Nightly build from 2024-04-04, under macOS 12.6.6.
Verified on Firefox RC 126.0-build1, build ID 20240506203248, using macOS 12.6.6, Windows 11 and Ubuntu 22.04 and Firefox View tab row buttons are now aligned to the right edge within the card containers, except for the "x" button from the "Import history from another browser" card - see the attached ss.
kcochrane, should I reopen this bug or file a new one? Thank you in advance!

Comment 7

[Kelly Cochrane [:kcochrane]]

Let's file this as a separate bug, please. This original bug was for aligning buttons to the right for tab row items, and I believe this import banner is just setup differently than those padding-wise. Thanks!

Comment 8

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Thank you for the confirmation! Will file a separate bug.
Based on Comment 6 I am marking this verified as fixed.