1880542 - Refactor fxview-tab-list and fxview-tab-row

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P1)

Description

[Sarah Clements [:sclements]]

These components have gotten more complex with the addition of tab indicators and pinned tabs. Simple use cases don't need more than a title and url (for the sidebar), and even within firefox view, only Open Tabs needs to care about the tab indicator and pinned tab logic.
A few ideas:

• Can we make the fxview-tabs-list more generic by moving handleFocusElementInRow to be handled by row elements? then we can create and slot in different custom row elements to the list depending on the use case? Might need to use lit context for any logic/state handled in the list.
• Then have fxview-tab-row-simple be a base class from which others could extend, ie fxview-tab-row, fxview-open-tabs-row, etc.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1880542 - Refactor fxview-tab-list and fxview-tab-row r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfd96ba0e091
Refactor fxview-tab-list and fxview-tab-row r=sfoster,fxview-reviewers,jsudiaman

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dfd96ba0e091