1895516 - “x” button from “Import history..” banner from Firefox View is not aligned with the right edge of the card’s inner padding

Status: REOPENED

(Firefox :: Firefox View, defect, P5)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: "x" button not right aligned

Found in

• 126.0 RC-build 1

Affected versions

• 127.0a1 (2024-05-06)
• 126.0 RC-build1
• 125.0.3

Tested platforms

• Affected platforms: Windows 11, macOS 12.6.6, Ubuntu 22.04
• Unaffected platforms: none

Steps to reproduce

1. Open a few websites and navigate to the Firefox View tab
2. Click on the History option from the left side of the page
3. Observe the alignment of the “x” button from the “Import history from another browser” banner

Expected result

• The “x” button does align with the right edge of the card’s inner padding

Actual result

• The “x” button does not align with the right edge of the card’s inner padding

Regression range

• Last good build: 2024-04-05
• First bad build: 2024-04-06
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c230ec8f9514326a6e5081ee8e2d677ccf10ab67&tochange=b015e423be91c58d7b97894c9edf76dd65a7c5aa
• Potentially regressed by: Bug 1889769

Additional notes

• See the attached ss
• Not reproducing for the buttons from the tab row row items (fixed in Bug 1889769)

Comment 1

[Donal Meehan [:dmeehan]]

: bhidecuti can you confirm the regressor?
Comment 0 indicates that 125.0.3 is affected but the regressor is only in 126+

Comment 2

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

dmeehan, after further investigation it seems that the issue was reproducing since the implementation but it was fixed in Firefox Nightly 126.0a1 (2024-03-27) by Bug 1880542. This is why I am also able to reproduce it with Firefox 125.0.3.
Starting with Firefox Nightly 126.0a1 (2024-04-06), I am able to reproduce it again. Please let me know if I can provide more details!

Comment 3

[Donal Meehan [:dmeehan]]

Thanks for the clarification.
Cleared the regression and resolving as fixed in 126 and 127 based on Comment 2

Comment 4

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

dmeehan, anytime. I want to point out that the issue is still reproducing in Firefox 126.0 RC-build1 and on the latest Firefox 127.0a1 Nightly, as mentioned in Comment 0.
The issue was introduced again in Firefox Nightly 126.0a1 (2024-04-06) by Bug 1889769.

Comment 5

[Donal Meehan [:dmeehan]]

Thank you for clarifying, Comment 4 is not what I read in Comment 2
Reopening for now so the bug is in the correct status

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

:kcochrane, since you are the author of the regressor, bug 1889769, could you take a look?

For more information, please visit BugBot documentation.