1890001 - [toolbar redesign] Focus toolbar margin

Status: RESOLVED FIXED

(Focus :: General, defect, P3)

Description

[Roger Yang [:royang]]

Attachment: Screenshot_20240405_124002.png

Only when cursor is not in the toolbar. This is probably caused by the toolbar redesign work. Please fix.

Comment 1

[jackyzy823]

Attachment: Bug 1890001 - Prevent parseInt error in Debug drawer. r=#android-reviewers

Comment 2

[Phabricator Automation]

Comment on attachment 9395385 [details]
Bug 1890001 - Prevent parseInt error in Debug drawer. r=#android-reviewers

Revision D206842 was moved to bug 1890011. Setting attachment 9395385 [details] to obsolete.

Comment 3

[Roger Yang [:royang]]

Looks like this is not a regression. This is due to displaytoolbar in Focus usually have the trash icon on the left. But when that's disabled, the padding issue shows up. This is something we should fix.

Comment 4

[Chris Peterson [:cpeterson]]

Which Focus versions are affected? Will we want to uplift this fix to 126 Beta?

Comment 5

[Mihai Adrian Carare [:mcarare]]

Regressed in 123 by 1864890.

Comment 6

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1890001 - Fix display toolbar start margin.

Comment 7

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Release blockers to priority P3 until we finish fixing our Beta experiment blockers.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1864890

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b15f2cf62441
Fix display toolbar start margin. r=android-reviewers,Roger

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b15f2cf62441

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mcarare, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Lorand Janos]

Couldn't reproduce on 126.0, 127.0b5 and 128.0a1 builds on a Samsung Galaxy S23 Ultra (Android 14) and a Google Pixel 7 (Android 15 - Beta 2).

Managed to reproduce on a Redmi 9C NFC (Android 10) on RC 126.0.

Verified as fixed on the same device on the latest Nightly build (128.0a1-20240523205926).

Comment 13

[Lorand Janos]

Attachment: Screenshot_2024-05-24-15-15-48-761_com.android.systemui.jpg

Comment 14

[Lorand Janos]

Comment on attachment 9403749 [details]
Screenshot_2024-05-24-15-15-48-761_com.android.systemui.jpg

Focus RC 126.0 and latest Focus Nightly 128.0a1

Comment 15

[Mihai Adrian Carare [:mcarare]]

This was once again regressed by https://bugzilla.mozilla.org/show_bug.cgi?id=1923115

Comment 16

[Donal Meehan [:dmeehan]]

(In reply to Mihai Adrian Carare [:mcarare] from comment #15)

This was once again regressed by https://bugzilla.mozilla.org/show_bug.cgi?id=1923115

It would be better for tracking purposed to track this regression in another bug