[Toolbar Redesign] Change the margin on the left from 24dp to 16dp for the address bar.
Categories
(Fenix :: Toolbar, defect, P2)
Tracking
(firefox131 unaffected, firefox132 unaffected, firefox133 fixed)
| Tracking | Status | |
|---|---|---|
| firefox131 | --- | unaffected |
| firefox132 | --- | unaffected |
| firefox133 | --- | fixed |
People
(Reporter: aarjav, Assigned: harrisono)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: perf-alert, regression, Whiteboard: [fxdroid][group3])
Attachments
(2 files)
Screenshot_20241004-121038.png
The margin on the left and right of the address bar is uneven. It should be 16 dp on both sides. Please also make sure it 16 dp on both sides for all toolbar states.
This is a release blocker for phase 1.
|
||
Comment 2•5 months ago
|
||
Sarah suspects this bug might be a regression from bug 1909751.
|
||
Comment 3•5 months ago
|
||
Set release status flags based on info from the regressing bug 1909751
:tchoh, since you are the author of the regressor, bug 1909751, could you take a look?
For more information, please visit BugBot documentation.
|
|
||
Comment 4•5 months ago
|
||
The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:
- Bug 1923172: S2
:royang, could you consider increasing the severity of this bug to S2?
For more information, please visit BugBot documentation.
|
||
Comment 5•5 months ago
|
||
No need to increase severity since this is a beta blocker.
|
||
Updated•5 months ago
|
|
||
Updated•5 months ago
|
|
Assignee | |
Updated•4 months ago
|
|
|
Assignee | |
Comment 6•4 months ago
|
||
|
||
Comment 9•4 months ago
|
||
(In reply to Pulsebot from comment #7)
Pushed by hoglesby@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afbcf280a8cf
Fix starting margin for toolbar redesign r=android-reviewers,tchoh
Perfherder has detected a browsertime performance change from push afbcf280a8cf87ef300d786dbd14b729686b9397.
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 38% | bild-de LastVisualChange | android-hw-a55-14-0-aarch64-shippable | warm webrender | 1,415.06 -> 881.11 |
| 33% | bild-de LastVisualChange | android-hw-a55-14-0-aarch64-shippable | cold webrender | 1,966.52 -> 1,326.70 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 42390
For more information on performance sheriffing please see our FAQ.
Description
•