1890731 - Create a TreeView wrapper that automatically handles the column and sort events

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

TreeView has the UI event listeners for many types of sorting and column arrangement events, but mostly it just forwards the events to be implemented elsewhere. Most instances of the element will handle these events in exactly the same way, so I'm creating a wrapper class which does all of that handling in a tidy, self-contained package. I hope to eventually move all of this logic into the TreeView class but for now I don't want to risk unintended changes in the existing uses, about:3pane and about:addressbook.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1890731 - Create a TreeView wrapper that automatically handles the column and sort events. r=aleca,freaktechnik

Comment 2

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

As a part of this I want to overhaul PROTO_TREE_VIEW (from jsTreeView.js) to make it capable of sorting the view without additional code, and to remove a bunch of nsITreeView cruft it will no longer need. The sorting can be done now, the cruft will have to wait until we stop using the XUL tree with JS views.

Comment 3

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1890731 - Begin replacing nsITreeView with TreeDataAdapter. r=aleca,freaktechnik

Comment 4

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1890731 - Add sorting to TreeDataAdapter. r=aleca,freaktechnik

Comment 5

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1890731 - Convert ABView into a TreeDataAdapter. r=aleca,freaktechnik

Comment 6

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1890731 - Replace XUL tree in contacts sidebar and search window with TreeViews. r=aleca,freaktechnik

Comment 7

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1890731 - Remove OS-specific styles from contacts sidebar and tidy up a little. r=#thunderbird-front-end-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be1edc170ed9
Create a TreeView wrapper that automatically handles the column and sort events. r=aleca
https://hg.mozilla.org/comm-central/rev/d8aa15c2c9dd
Begin replacing nsITreeView with TreeDataAdapter. r=freaktechnik,aleca
https://hg.mozilla.org/comm-central/rev/c58fd8188685
Add sorting to TreeDataAdapter. r=freaktechnik,aleca
https://hg.mozilla.org/comm-central/rev/b199369ce2dd
Convert ABView into a TreeDataAdapter. r=freaktechnik,aleca
https://hg.mozilla.org/comm-central/rev/d34f74e86210
Replace XUL tree in contacts sidebar and search window with TreeViews. r=aleca
https://hg.mozilla.org/comm-central/rev/c9ba6b258597
Remove OS-specific styles from contacts sidebar and tidy up a little. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Bug 1890731 - Fix the icon color. r=darktrojan

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/62d3362a0369
Fix the icon color. r=darktrojan