Closed
Bug 1890782
Opened 1 year ago
Closed 1 year ago
Add [[nodiscard]] to BounceTrackingProtection methods where missing
Categories
(Core :: Privacy: Anti-Tracking, task, P3)
Core
Privacy: Anti-Tracking
Tracking
()
RESOLVED
FIXED
127 Branch
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: emz, Assigned: emz)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Some of the BounceTrackingProtection functions return nsresult but don't require handling the result. We should enforce that via [[nodiscard]].
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → pbz
Status: NEW → ASSIGNED
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09168636f92e
Add [[nodiscard]] to BounceTrackingProtection methods where missing. r=manuel
|
||
Comment 3•1 year ago
|
||
Backed out alongside bug 1889444, bug 1888504, bug 1890546, bug 1888500, bug 1848406, bug 1890782 for causing bustage on BounceTrackingProtection.h
Flags: needinfo?(pbz)
|
|
Assignee | |
Comment 4•1 year ago
|
||
Try looks green now. Let's hope I didn't miss any tests :-)
Flags: needinfo?(pbz)
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9dbfe5089d48
Add [[nodiscard]] to BounceTrackingProtection methods where missing. r=manuel
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox127:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•