1891063 - Various preliminary clean-ups before bug 1850979

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891063 - Factor out some window style flags code. r=#win-reviewers

No behavior change intended. I plan to use this to hide the titlebar
buttons when drawing to the titlebar (we currently draw on top of them).

But seems worth factoring out regardless.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891063 - Remove unused code for transparency. r=#win-reviewers

Right now, we don't use top level transparent windows (they're
completely unused).

This removes some code that causes trouble when reintroducing them.

Depends on D207297

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891063 - Allow transparent top level windows to be accelerated. r=#win-reviewers

All the comments on this function are for platforms we don't support.

Right now we don't have any of these top-level transparent windows, but
we want to use DWM and Webrender for these just like for regular windows.

Depends on D207298

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891063 - Various clean-ups in windows widget code (no functional changes). r=#win-reviewers,#gfx-reviewers

Just some clean-ups that I accumulated while going over this code.

Depends on D207299

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891063 - Re-introduce some of the opaque region handling removed in bug 1844241. r=#win-reviewers

Again, dead code for now because the windows are always opaque,
but will be useful later on since this allows restricting the
region that needs to have transparency.

Depends on D207300

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891063 - Improve invalidation of top-level transparent windows. r=#win-reviewers

This shouldn't matter in practice for popups, but we need to do it for
top levels, where otherwise DWM won't re-paint the backdrop material.

Depends on D207301

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdb5dbc1e980
Factor out some window style flags code. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/24dc60b32e21
Remove unused code for transparency. r=win-reviewers,rkraesig

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f44d19bb3a9
Allow transparent top level windows to be accelerated. r=win-reviewers,gfx-reviewers,rkraesig,nical

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05f93e8ade3c
Various clean-ups in windows widget code (no functional changes). r=win-reviewers,gfx-reviewers,bradwerth,rkraesig

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bdb5dbc1e980
https://hg.mozilla.org/mozilla-central/rev/24dc60b32e21

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3439db7ee7a0
Backed out changeset 1f44d19bb3a9 for causing bc failures on browser_test_autoscrolling_in_extension_popup_window.js CLOSED TREE

Comment 12

[Aron Cseh]

• Backout link
• Push with failures
• Failure Log

Comment 13

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/05f93e8ade3c

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Yikes, I forgot to add the leave-open keyword again...

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d666fbf5ef4
Allow transparent top level windows to be accelerated. r=win-reviewers,gfx-reviewers,rkraesig,nical

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1d666fbf5ef4

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891063 - Simplify non-client-area event handling. r=#win-reviewers

If we are using custom non-client area (mCustomNonClient) suppress more
directly the default windows actions in WM_NCPAINT / WM_NCACTIVATE.

This prevents titlebars showing up when using custom non-client areas
in semi-transparent windows.

Depends on D207302

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/294255d72503
Re-introduce some of the opaque region handling removed in bug 1844241. r=win-reviewers,rkraesig

Comment 19

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/294255d72503

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Ray, can you attach a screenshot of what you're seeing in https://phabricator.services.mozilla.com/D208255#7152576? Thanks.

Also, just confirming that you tested that on top of https://phabricator.services.mozilla.com/D207302 (which is what clears the NC Area)

Comment 21

[Ray Kraesig [:rkraesig]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #20)

Ray, can you attach a screenshot of what you're seeing in https://phabricator.services.mozilla.com/D208255#7152576? Thanks.

Also, just confirming that you tested that on top of https://phabricator.services.mozilla.com/D207302 (which is what clears the NC Area)

I can confirm the latter now; I piggybacked on the Phabricator-launched try job to create the build. I'll post a screenshot shortly.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/717a883474be
Improve invalidation of top-level transparent windows. r=win-reviewers,rkraesig,handyman

Comment 23

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/717a883474be

Comment 24

[Emilio Cobos Álvarez (:emilio)]

I'll land other patches in other bugs to ease tracking.