1894298 - bookmark/history menupopup are not displayed after the second time.

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P2)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: bookmark menupopup are not displayed after the second time.

Step to reproduce:

1. Create a folder on Bookmarks toolbar
2. Create a lot of bookmarks and separator in the folder (maybe depended on number of item and height of popup etc)
3. Restart Browser if any
4. Click the folder
   --- all bookmarks item are displayed
5. Click the folder twice
   --- The top half (and bottom part) of the menupopup is not displayed
6. Move the mouse to where the menupopup should be
   --- The rest will be displayed

Actual results:
The first half of the menupopup is not displayed.
Screencast: https://youtu.be/B9IrmMGYRHA

Expected results:
Whole of the menupopup should be displayed.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=56770cf9b51ad1b01ef17f5393a56f4c08655e46&tochange=717a883474bedbbf5f420ffd52c76d3f6d4b910d

Comment 1

[Alice0775 White]

Attachment: about:config

Comment 2

[Alice0775 White]

Attachment: bookmarks.json

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1891063, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Fairly sure bug 1894135 should fix this, but let's keep this open in case it doesn't. Please ni? me again if so :)

Comment 5

[Alice0775 White]

Attachment: sample bookmark: bookmarks-2024-05-02.json

Comment 6

[Alice0775 White]

This problem is still reproduced on autoland build (changeset 4612b726c541 Bug 1894135 - Fix tooltip / unaccelerated transparent window rendering regression. r=win-reviewers,rkraesig).

@emilio, could you please look into this again?

Comment 7

[Alice0775 White]

This problem seems to occur when the title of a bookmark contains the emoji like "🦊" and "‼️".
screencast : https://youtu.be/KQjm8uyI8WM

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox127 (nightly). We have limited time to fix this, the soft freeze is in 7 days. However, the bug still isn't assigned.

:gcp, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 10

[Alice0775 White]

History menupopup is also affected: https://youtu.be/zDNqmJQpEqM

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1894298 - Make sure that transparent popups repaint the transparent area even if not resized. r=#win-reviewers

For popups that end up using WR we do need to repaint the transparent
area on show. Otherwise we end up with an empty invalidation region and
part of the window might not show.

I need to admit I haven't quite figured out why it'd partially show, but
in any case this restores behavior.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1891063

Comment 15

[Emilio Cobos Álvarez (:emilio)]

This was fixed by backout.