1891666 - 171.54% compiler warnings (Windows) regression on Tue April 9 2024

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push ac55c45e0d0f78544391702bda11cab09c0e60b0. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
172%	compiler warnings	windows2012-64-shippable	nightly	490.17 -> 1,331.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

You can run these tests on try with ./mach try perf --alert 42206

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1871963

Comment 2

[Donal Meehan [:dmeehan]]

Could this be triaged for severity?
Setting Fx126 as optional since it's not a user issue and Fx126 is now in beta
Wondering if a fix will be prioritized for fx127 at least or later?

Comment 3

[Kershaw Chang [:kershaw]]

It's probably not easy to fix since I assume those warnings are from the 3rd party library.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:jesup, since you are the author of the regressor, bug 1871963, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

I'll see if we can add something to suppress the warning in the external zstd library

Comment 7

[Valentin Gosu [:valentin] (he/him)]

I guess we could remove these flags here - if we think these warnings are really meant to be suppressed. Otherwise we can WONTFIX it?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

It's a LOT of warning spam in the console (which I believe can actually impact build times as well). We should not WONTFIX this bug and I hope we can prioritize fixing it soon.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1891666: remove -Wall from zstd compile options (windows dislikes it) r=#necko-reviewers!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef3141d05710
remove -Wall from zstd compile options (windows dislikes it) r=necko-reviewers,valentin

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ef3141d05710