1892762 - [toolbar redesign] Snackbar blocks access to address bar or toolbar

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect, P1)

Description

[Roger Yang [:royang]]

Attachment: Screen_recording_20240422_122854.webm

When adding or removing a bookmark through the menu, the undo snack bar can block access to the addressbar (deleting bookmark) or toolbar (adding bookmark).

Comment 1

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Beta experiment blockers to priority P2 until we finish fixing our Nightly blockers.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1892762 - part 1 - Ensure that browser screen snackbars are shown on top of the navbar r=#android-reviewers

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1892762 - part 3 - Ensure snackbars for deleted bookmarks are shown above (vertically) the browser navbar r=#android-reviewers

The snackbar for deleting a just added bookmark is shown from the bookmarks screen which does
not have access to browser's toolbar to anchor the snackbar to it.
The previous approach would use a boolean to know when to use the hardcoded height of the toolbar
as a padding for the snackbar.
With the navigation bar potentially doubling the height of the toolbar (when the toolbar is placed
on bottom of the screen) that approach seems like a hack that is hard to maintain.

The new approach has the browser screen informing the browser screen about a successfully deleted
bookmark and the browser screen can show a confirmation snackbar anchored to it's toolbar.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1892762 - part 4 - Snackbars cleanup in the browser screen r=#android-reviewers

Use the simpler method to create a snackbar for all such scenarios.
Avoid duplicated code.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Fixed snackbar placement

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1892762 - part 2 - Allow passing a string for snackbar text and action r=#android-reviewers

This is useful when the text needed to be used is a literal string and not
one existing as a string resource that can be requested by it's id.

Comment 7

[Chris Peterson [:cpeterson]]

Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1892762 - Part 4 - Ensure snackbars for deleted bookmarks are shown in the bookmarks screen r=#android-reviewers

With the snackbar for when the bookmark is deleted moved to the AppStore when the bookmark
is deleted from the the edit screen of a bookmark we need to consume the AppState in the
bookmarks screen also.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1892762 - part 5 - Disable failing deleteBookmarkInEditModeTest r#mobiletest-reviewers r=#android-reviewers

Test started to fail though if observing the flow everything runs as expected.
More information in bug 1909187.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd462a4aa0b6
part 1 - Ensure that browser screen snackbars are shown on top of the navbar r=android-reviewers,tthibaud
https://hg.mozilla.org/integration/autoland/rev/a529c2fb1e73
part 2 - Allow passing a string for snackbar text and action r=android-reviewers,gl,Roger
https://hg.mozilla.org/integration/autoland/rev/705ed5a56fcd
part 3 - Ensure snackbars for deleted bookmarks are shown above (vertically) the browser navbar r=android-reviewers,gl
https://hg.mozilla.org/integration/autoland/rev/7506e8b6ecd8
Part 4 - Ensure snackbars for deleted bookmarks are shown in the bookmarks screen r=android-reviewers,gl
https://hg.mozilla.org/integration/autoland/rev/fff95abc79d6
part 5 - Disable failing deleteBookmarkInEditModeTest r#mobiletest-reviewers r=android-reviewers,gl

Comment 13

[Aaron Train [:aaronmt]]

Hey folks, it looks like this breaks a couple bookmark tests

https://console.firebase.google.com/u/1/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/8077484313341467328/details?stepId=bs.ec4fea82f5fd5222&testCaseId=1&tabId=video

• copyBookmarkURLTest
• cantSelectDefaultFoldersTest
• deleteBookmarkInEditModeTest

Petru, can you take a look?

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Indeed, there's an issue affecting bookmarks screen tests that show a snackbar, no issue in the actual functionality.
More context in bug 1909569.

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cd462a4aa0b6
https://hg.mozilla.org/mozilla-central/rev/a529c2fb1e73
https://hg.mozilla.org/mozilla-central/rev/705ed5a56fcd
https://hg.mozilla.org/mozilla-central/rev/7506e8b6ecd8
https://hg.mozilla.org/mozilla-central/rev/fff95abc79d6

Comment 16

[Delia Pop (Android QA)]

Verified as fixed in the latest Nightly 130.0a1 from 07/31 with Google Pixel 8 Pro (Android 14) and Xiaomi 12 Pro (Android 13).

Comment 17

[Petru-Mugurel Lingurar [:petru]]

Seems like there have been no new reports of related tests failing in bug 1909569.
Removing my NI which I used as a reminder to check.