1908596 - [Toolbar Redesign] Several snackbars overlap the Navigation bar and/or the address bar

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Delia Pop]

Attachment: Snackbars.png

Steps to reproduce

1. Perform the following actions that trigger a snackbar.
2. Observe the snackbar.

a. add a bookmark -> Open a webpage, open the three-dot menu, tap the bookmark's "Add" button.
b. delete bookmark from edit view -> Bookmark a webpage, then tap the 3-dot menu button from the Navigation toolbar, and tap the "Edit" button next to the Bookmarks option. > Tap the trashcan icon in the top-right corner. > Tap on the DELETE option from the dialogue.
c. close all tabs from tabs tray -> Open several tabs and open the Tabs Tray. > Tap the ⋮ button. Select "Close all tabs" from the overlay. - only when address bar is positioned to top
d. save to collection from 3 dot menu -> Open a webpage, open the three-dot menu and tap the "Save to collection" option. > Fill in the name. > Save.
e. rename collection -> Create a new collection (or use an existing one). > Expand the collection and tap the collection menu, select Rename collection. > Rename the collection. > Tap the Ok (enter) button from the keyboard.
f. delete collection -> Create a new collection (or use an existing one). > Expand the collection and open the overflow menu, tap Delete collection.
g. add a website to shortcuts -> Open a webpage, open the three-dot menu and tap the "Add to shortcuts" option.
h. remove a website from shortcuts -> Long tap the pinned shortcut from homepage, then select "Remove". or open the three-dot menu and tap the "Remove from shortcuts" option.
i. copy URL -> Open a webpage > Long tap the URL > Tap "Copy"
j. context menu options -> Open a webpage > Long tap a link > Tap "Open link in new tab"
k. context menu options -> Open a webpage > Long tap a link > Tap "Open link in private tab"
l. context menu options -> Open a webpage > Long tap a link > Tap "Copy link"
m. context menu options -> Open a webpage > Long tap a linked image > Tap "Open image in new tab"
n. context menu options -> Open a webpage > Long tap a linked image > Tap "Open image location"

Expected behavior

The snackbars do not overlap the navigation bar/the address bar.

Actual behavior

Several snackbars are displayed on top of the navigation bar/the address bar.

Device information

• Firefox version: Nightly 130.0a1 from 07/18
• Android device model: Google Pixel 8 Pro
• Android OS version: Android 14

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: SnackbarForCopyFromShareMenuOverlapsNavbar.mp4

From working to fix these scenarios and testing in between it seems like all snackbars from our share menu will overlap the navbar (irrespective of the toolbar location - to top or bottom).
Snackbars shown from this feature (actually shown in the browser screen):

• error when sharing to app
• successfully sharing tabs
• failure in sharing tabs
• copy to clipboard (also conflicts with Android's default popup on Android 13+)

Comment 2

[Petru-Mugurel Lingurar [:petru]]

This should be fixed as a result of fixing bug 1906657
@ QA please help test if the issues reported here dissapeared.

Comment 3

[Delia Pop]

Verified as fixed in the latest Nightly 130.0a1 from 07/31 with Google Pixel 8 Pro (Android 14) and Xiaomi 12 Pro (Android 13). All the above mentioned snackbars are displayed above the navigation bar/address bar, regardless of the address bar position.
On devices with Android 13+, the "URL copied to clipboard" snackbar is no longer displayed, since the OS pop-up is triggered when copying the URL.
However, there are 3 snackbars still displayed overlapped by the OS copy to clipboard pop-up, as follows:

1. context menu options -> Open a webpage > Long tap a link > Tap "Copy link"
2. context menu options -> Open a webpage > Long tap a linked image > Tap "Copy image location”
3. context menu options -> Open a webpage > Long tap a linked image > Tap "Copy link"
   These cases can be handled in 1802247.