189277 - "Mark newsgroup read" doesn't work if focus is on a different folder

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

Right-clicking on a newsgroup (with a different newsgroup in focus), and
selecting "mark newsgroup read", appears to work at first... it drops the
boldface and shows no unread messages. But after left-clicking on that newsgroup
(setting focus), the unread messages appear again.

This only occurs when the focus is on a different newsgroup, and only if the
newsgroup hasn't been selected beforehand (with those same unread messages). For
instance, if I focus the newsgroup in question, and then focus a different one,
then mark all messages read as detailed above, this problem doesn't appear (i.e.
it only appears in newsgroups with newly unread messages).

Steps to reproduce:
1. Select a newsgroup
2. Right-click on another newsgroup with newly unread messages, and select "mark
newsgroup read"
3. Left-click on that newsgroup; messages reappear unread.

Comment 1

[[e-mail]]

Sorry, one last note - reported on Moz 1.2/Win32.

Comment 2

[Todd Gearhart]

I was unable to reproduce bug on 2003011508 (win 2000 sp1).

Reporter, try to download a more recent build and check if you can still
reproduce the bug. 

Comment 3

[[e-mail]]

Reproducible on 1.3b/win2k. Reproducible with a new profile also, fwiw...

Can you double-check that you followed the steps to reproduce correctly?

FWIW, here's what I think is happening...
Without clicking on a newsgroup, only a new message count is downloaded... not
the actual headers. So when you click on the newsgroup and the headers are
downloaded, it can't tell which messages to mark as new and which not to, so
they all get marked as new again.

If this is correct, I see two solutions:
a) disable the 'mark newsgroup read' option if the newsgroup doesn't have focus
(eww)
b) force the downloading of headers even when the newsgroup doesn't have focus
(bandwidth issue for dialup users?)

c) might work: save the timestamp when the user selects "mark newsgroup read"
without focus, and then mark all messages read with a posttime earlier than that
datestamp, when the headers are downloaded.

Comment 4

[Mike Cowperthwaite]

Reproduced in 1.4RC3.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

Comment 5

[Mike Cowperthwaite]

*** Bug 203405 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Cowperthwaite]

This bug appears to have been fixed in 1.5RC1.  Dan Witte, when you upgrade to a 
1.5 build (RC1 or later), please verify; if the program now works as expected, 
mark this bug   Resolved|WorksForMe.

Comment 7

[[e-mail]]

confirmed broken on 20030926 linux trunk. are you sure you've seen this fixed on
the 1.5 branch?

Comment 8

[Mike Cowperthwaite]

My mistake, I didn't test this deeply enough.  It is still broken.

Comment 9

[Daniel Guggi]

reproduced bug under: Mozilla1.5 

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031202

Comment 10

[Scott MacGregor]

*** Bug 218859 has been marked as a duplicate of this bug. ***

Comment 11

[Himanshu J Gohel[:hgohel]]

Reproducible in Mozilla 1.8a4 and Thunderbird 0.8 on Windows.

Comment 12

[Hendrik Maryns]

Can confirm this on TB1.0.6 Versie 1.0.6 (20050716) and on the latest (dutch)
nightly, Versie 1.5 Beta 1 (20050916)

This is what my FF about says (this information does not show up in TB?):
Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.10) Gecko/20050717 (No IDN) 

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to comment #12)
> Can confirm this on TB1.0.6 Versie 1.0.6 (20050716) and on the latest (dutch)
> nightly, Versie 1.5 Beta 1 (20050916)

this is TB Bug 250070

Comment 14

[Jim Porter (:squib)]

This works for me in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3pre) Gecko/20090821 Shredder/3.0b4pre

Comment 15

[Himanshu J Gohel[:hgohel]]

Able to reproduce the behavior described in this defect in Thunderbird version 2.0.0.23 (20090812) on Windows XP.  So, "still not working for me."

Comment 16

[Jim Porter (:squib)]

Ah. It works for me when new messages haven't come in since the last time I looked at the message list. Otherwise, it will only mark-as-read the messages that I already have headers for. So the easy solution is to download headers before marking things as read.

Comment 17

[Jim Porter (:squib)]

(In reply to comment #16)
> Ah. It works for me when new messages haven't come in since the last time I
> looked at the message list. Otherwise, it will only mark-as-read the messages
> that I already have headers for. So the easy solution is to download headers
> before marking things as read.

And of course, this has already been covered in this report. That's what I get for looking at several similar reports. :(

Comment 18

[Jim Porter (:squib)]

Attachment: Simple patch

Is it really as simple as this? (Probably not.)

There are two calls to markAllMessagesRead so that it appears to work immediately and then marks any new messages read after that.

Comment 19

[Dan Mosedale (:dmosedale, :dmose)]

Since the patch you've got here is for Thunderbird, I suspect it really wants to live in bug 250070, which is the TB version of this bug.  I can see why this fix works, but it seems somewhat hacky.  Maybe ask bienvenu if he knows of a cleaner way to fix it over in that bug?

Comment 20

[Jim Porter (:squib)]

Whoops! I'll move discussion over to bug 250070. Whatever the fix is, though, it'll probably be identical.

Comment 22

[Frank-Rainer Grahl (:frg)]

In general this works for me. The case where you mark a folder as read and then get new messages for the account later is not covered but as in the TB bug states this isn't really a bug. I wouldn't want messages which were not there in the first place marked as read even if they were older.