1892931 - Perma Late Beta TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_contextmenu_sendpage.js | Ids in context menu match expected values - "frame-sep" == "context-translate-selec when Gecko 127 switches from Early Beta to Late Beta on 2024-05-24

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Aron Cseh]

Central-as-beta simulation
How to run these simulations
Failure log:

[task 2024-04-23T11:02:42.351Z] 11:02:42     INFO - TEST-PASS | browser/base/content/test/sync/browser_contextmenu_sendpage.js | Ids in context menu match expected values - "context-searchselect" == "context-searchselect" - 
[task 2024-04-23T11:02:42.351Z] 11:02:42     INFO - Buffered messages finished
[task 2024-04-23T11:02:42.354Z] 11:02:42     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_contextmenu_sendpage.js | Ids in context menu match expected values - "frame-sep" == "context-translate-selection" - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js","name":"test_link_contextmenu","sourceId":624,"lineNumber":146,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":575,"lineNumber":1139,"columnNumber":26,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":575,"lineNumber":1211,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":575,"lineNumber":1353,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":575,"lineNumber":1128,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":602,"lineNumber":1058,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"test_link_contextmenu@chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js:146:12\nasync*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}}
[task 2024-04-23T11:02:42.354Z] 11:02:42     INFO - Stack trace:
[task 2024-04-23T11:02:42.355Z] 11:02:42     INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js:test_link_contextmenu:146
[task 2024-04-23T11:02:42.355Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-04-23T11:02:42.355Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-04-23T11:02:42.355Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-04-23T11:02:42.356Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-04-23T11:02:42.356Z] 11:02:42     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-04-23T11:02:42.359Z] 11:02:42     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-04-23T11:02:42.361Z] 11:02:42     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_contextmenu_sendpage.js | Ids in context menu match expected values - "context-inspect-a11y" == "frame-sep" - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js","name":"test_link_contextmenu","sourceId":624,"lineNumber":146,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":575,"lineNumber":1139,"columnNumber":26,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":575,"lineNumber":1211,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":575,"lineNumber":1353,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":575,"lineNumber":1128,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":602,"lineNumber":1058,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"test_link_contextmenu@chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js:146:12\nasync*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}}
[task 2024-04-23T11:02:42.362Z] 11:02:42     INFO - Stack trace:
[task 2024-04-23T11:02:42.362Z] 11:02:42     INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js:test_link_contextmenu:146
[task 2024-04-23T11:02:42.362Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-04-23T11:02:42.362Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-04-23T11:02:42.362Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-04-23T11:02:42.362Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-04-23T11:02:42.362Z] 11:02:42     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-04-23T11:02:42.363Z] 11:02:42     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-04-23T11:02:42.367Z] 11:02:42     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_contextmenu_sendpage.js | Ids in context menu match expected values - "context-inspect" == "context-inspect-a11y" - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js","name":"test_link_contextmenu","sourceId":624,"lineNumber":146,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":575,"lineNumber":1139,"columnNumber":26,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":575,"lineNumber":1211,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":575,"lineNumber":1353,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":575,"lineNumber":1128,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":602,"lineNumber":1058,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"test_link_contextmenu@chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js:146:12\nasync*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}}
[task 2024-04-23T11:02:42.367Z] 11:02:42     INFO - Stack trace:
[task 2024-04-23T11:02:42.367Z] 11:02:42     INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js:test_link_contextmenu:146
[task 2024-04-23T11:02:42.367Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-04-23T11:02:42.367Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-04-23T11:02:42.367Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-04-23T11:02:42.368Z] 11:02:42     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-04-23T11:02:42.368Z] 11:02:42     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-04-23T11:02:42.368Z] 11:02:42     INFO - TEST-PASS | browser/base/content/test/sync/browser_contextmenu_sendpage.js | Send link to device is shown - 

Comment 1

[Erik Nordin [:nordzilla]]

Oh no!

I just landed Bug 1890299 last night and had a bit of trouble getting it landed due to these context menu tests failing.

I fixed all the failing test cases by adding my new menu item, but now I see that it's caused this failure for late beta.

I think I'm going to have to make the test case assertions themselves dependent on the pref's enabled state, similar to this:

https://searchfox.org/mozilla-central/rev/eb4700a6be8371fe07053bc066c2d48ba813ce3d/browser/base/content/test/contextMenu/browser_contextmenu.js#91-94

I will write a patch to fix this today.

Comment 2

[Natalia Csoregi [:nataliaCs]]

Also failing, in the same context:
TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu.js | checking item #12 (context-translate-selection) name - Got "---", expected "context-translate-selection"

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892931 - Fix browser_contextmenu.js test when SelectTranslations is disabled r=#translations-reviewers!

Fixes the browser_contextmenu.js test to not expect the
SelectTranslations context menu item is the pref is disabled.

Comment 4

[Erik Nordin [:nordzilla]]

I've pushed up a patch that makes the browser/base/content/test/contextMenu/browser_contextmenu.js test aware of the pref's enabled state and changes the assertions accordingly.

This should fix the issue in Late Beta.

I tested this by manually setting the relevant prefs in firefox.js to all combinations of false/true manually before running the tests, and the test cases passed for each combination.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/739e70f2e5e8
Fix browser_contextmenu.js test when SelectTranslations is disabled r=translations-reviewers,gregtatum

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/739e70f2e5e8

Comment 7

[Serban Stanca [:SerbanS]]

Patch doesn't seem to work in today's central as late-beta simulation. Could you please take another look at this?

Thank you!

Comment 8

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892931 - Fix browser_contextmenu_sendpage.js test when SelectTranslations is disabled r=#translations-reviewers!

Fixes the browser_contextmenu_sendpage.js test to not expect the
SelectTranslations context menu item is the pref is disabled.

Comment 9

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892931 - Make browser_contextmenu_sendpage.js more declarative r=#translations-reviewers!

Makes the assertions in browser_contextmenu_sendpage.js
more declarative and more maintainable for adding new
items to the context menu.

Depends on D208765

Comment 10

[Erik Nordin [:nordzilla]]

It seems that I fixed the issue for the browser_contextmenu.js test, but not the browser_contextmenu_sendpage.js test, which I didn't notice was also failing.

I've pushed up patches for that test too.

Comment 11

[Natalia Csoregi [:nataliaCs]]

The patches are working in today's beta-sim: link

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/205d14d6885f
Fix browser_contextmenu_sendpage.js test when SelectTranslations is disabled r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/8f7500d7e530
Make browser_contextmenu_sendpage.js more declarative r=translations-reviewers,gregtatum

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/205d14d6885f
https://hg.mozilla.org/mozilla-central/rev/8f7500d7e530

Comment 14

[Sandor Molnar[:smolnar]]

Verified fixed in today's beta-sim