1890299 - Enable Select Translations for Nightly and Early Beta

Status: RESOLVED FIXED

(Firefox :: Translations, task, P3)

Description

[Erik Nordin [:nordzilla]]

We should enable Select Translations for Nightly and Early beta to get early feedback while it is under development.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1890299 - Enable Select Translations for Nightly and Early Beta r=#translations-reviewers!,sfoster

Enables Select Translations for EARLY_BETA_OR_EARLIER
to get early feedback on the implemented functionality.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24c16fd3e129
Enable Select Translations for Nightly and Early Beta r=marco

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing multiple mochitests failures.

• Backout link

---

• Push with failures - some mochitests
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_contextmenu_sendpage.js | Ids in context menu match expected values - "context-translate-selection" == "frame-sep" - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/sync/browser_contextmenu_sendpage.js","name":"test_link_contextmenu","sourceId":627,"lineNumber":145,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochi

---

• Push with failures - other mochitests
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/originattributes/test/browser/browser_firstPartyIsolation_saveAs.js | A promise chain failed to handle a rejection: WindowGlobalParent.getActor: Window protocol 'Translations' doesn't match uri about:blank - stack: getTranslationsActor@resource://gre/actors/TranslationsParent.sys.mjs:489:51

---

• Push with failures - another mochitests
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug724239.js | A promise chain failed to handle a rejection: WindowGlobalParent.getActor: Window protocol 'Translations' doesn't match uri about:blank - stack: getTranslationsActor@resource://gre/actors/TranslationsParent.sys.mjs:489:51

---

• Push with failures - another mochitests
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_contextmenu_openlink_after_tabnavigated.js | A promise chain failed to handle a rejection: WindowGlobalParent.getActor: Window protocol 'Translations' doesn't match uri about:blank - stack: getTranslationsActor@resource://gre/actors/TranslationsParent.sys.mjs:489:51

---

• Push with failures - another mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_image_mimetype_issues.js | A promise chain failed to handle a rejection: WindowGlobalParent.getActor: Window protocol 'Translations' doesn't match uri data:text/html,<a href="http://example.com/browser/browser/components/downloads/test/browser//not-really-a-jpeg.jpeg?convert=web - stack: getTranslationsActor@resource://gre/actors/TranslationsParent.sys.mjs:489:51

---

• Push with failures - other mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_contextMenus_targetUrlPatterns.js | A promise chain failed to handle a rejection: WindowGlobalParent.getActor: Window protocol 'Translations' doesn't match uri moz-extension://6cd13e96-fe94-428d-a269-a7c64350826c/testrunner.html - stack: getTranslationsActor@resource://gre/actors/TranslationsParent.sys.mjs:489:51

Comment 4

[Erik Nordin [:nordzilla]]

I believe I've resolved the issues.

Try looks clean to me:
https://treeherder.mozilla.org/jobs?repo=try&revision=b9e13becbe76e65c31ef4caff60199d0babfe612&selectedTaskRun=egiivzMsQbGGwgyiAmjl4w.0

Going to try re-landing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8a7b57f4e03
Enable Select Translations for Nightly and Early Beta r=translations-reviewers,gregtatum

Comment 6

[Iulian Moraru]

Backed out for causing bc failures on browser_contextmenu.js related to translate.

• Push with failures

• Failure log

• Backout link

[task 2024-04-17T19:49:40.924Z] 19:49:40     INFO - TEST-PASS | browser/base/content/test/contextMenu/browser_contextmenu.js | menuitem context-translate-selection has a label - 
[task 2024-04-17T19:49:40.926Z] 19:49:40     INFO - Buffered messages finished
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu.js | menuitem context-translate-selection has an access key - 
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - Stack trace:
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochikit/content/browser-test.js:test_ok:1592
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:getVisibleMenuItems:82
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:checkMenu:239
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:checkContextMenu:151
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:test_contextmenu:420
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/browser_contextmenu.js:test_xul_text_link_label:88
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-04-17T19:49:40.928Z] 19:49:40     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-04-17T19:49:40.929Z] 19:49:40     INFO - TEST-PASS | browser/base/content/test/contextMenu/browser_contextmenu.js | --- seperator id is frame-sep - 

Comment 7

[Erik Nordin [:nordzilla]]

Attachment: Bug 1890299 - SelectTranslations Context MenuItem an AccessKey r=#fluent-reviewers!

Provides an access key for the SelectTranslations
menu item in the right-click context menu.

Comment 8

[Erik Nordin [:nordzilla]]

I've fixed that failing test case in browser/base/content/test/contextMenu/browser_contextmenu.js.

Queuing for re-landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f973c15b6002
SelectTranslations Context MenuItem an AccessKey r=fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/7c9debaaa66e
Enable Select Translations for Nightly and Early Beta r=translations-reviewers,gregtatum

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f973c15b6002
https://hg.mozilla.org/mozilla-central/rev/7c9debaaa66e

Comment 11

[Donal Meehan [:dmeehan]]

:nordzilla could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Comment 12

[Erik Nordin [:nordzilla]]

Sure!

I will check with my team today to see if product/UX has any specific wording that they want, and nominate this bug.

Leaving my NI open for now.

Comment 13

[Erik Nordin [:nordzilla]]

Release Note Request (optional, but appreciated)

[Why is this notable]:

Enables the ability to translate selections of text in Firefox Nightly, rather than only being able to translate the entire web page.

[Affects Firefox for Android]:

No.

[Suggested wording]:

(NOTE: I don't have a preferred wording here, but I'll try. My team did not seem to have a preference.)

Translate selections of text from the right-click context menu in Firefox Nightly.

[Links (documentation, blog post, etc)]:

(NOTE: I don't think our SUMO article is ready yet Bug 1867825)

I'm not aware of any link or documentation yet since this only available in Nightly/Early beta at this time.

Comment 14

[Dianna Smith [:diannaS]]

Added to the nightly release notes for 127.
https://www.mozilla.org/en-US/firefox/127.0a1/releasenotes/

Comment 15

[Ryan VanderMeulen [:RyanVM]]

This rode the trains to release in bug 1870366 and was included in those relnotes. Removing the Nightly-only flag from this bug.