1893655 - Turn horizontal tabstrip vertically

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Sarah Clements [:sclements]]

We'll be taking the horizontal tabstrip and making it work vertically, which will require fixing Customizable UI and BrowserUsageTelemetry. This will be the first step to getting it into a semi-functional state and fixing any broken tests. Fixing drag n' drop will be spun off to another bug, as will the styling changes.

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1893655 - Set up the tabstrip to work vertically r=Dao,#sidebar-reviewers

• Add ability to move tabstrip into the sidebar based on a pref

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c5bb1ba9d20
Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs

Comment 3

[Iulian Moraru]

Backed out for causing bc failures on browser_vertical_tabs.js.

• Push with failures

• Failure log

• Backout link

[task 2024-06-14T14:00:50.290Z] 14:00:50     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_vertical_tabs.js | Sidebar is shown. - 
[task 2024-06-14T14:00:50.291Z] 14:00:50     INFO - Buffered messages finished
[task 2024-06-14T14:00:50.295Z] 14:00:50     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_vertical_tabs.js | Vertical tabs slot is hidden - 
[task 2024-06-14T14:00:50.295Z] 14:00:50     INFO - Stack trace:
[task 2024-06-14T14:00:50.295Z] 14:00:50     INFO - chrome://mochikit/content/browser-test.js:test_ok:1598
[task 2024-06-14T14:00:50.295Z] 14:00:50     INFO - chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_vertical_tabs.js:test_toggle_vertical_tabs:28
[task 2024-06-14T14:00:50.295Z] 14:00:50     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-06-14T14:00:50.295Z] 14:00:50     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-06-14T14:00:50.296Z] 14:00:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1359
[task 2024-06-14T14:00:50.296Z] 14:00:50     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-06-14T14:00:50.296Z] 14:00:50     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-06-14T14:00:50.296Z] 14:00:50     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_vertical_tabs.js | Tabstrip is in default horizontal position - 

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dc1daaeb256
Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1dc1daaeb256