1899336 - Style pinned tabs and add new tab button with divider to vertical tabs

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P1)

Description

[Sarah Clements [:sclements]]

I didn't include this in my initial patch in bug 1893655 because it looked to be more involved and requires changing how pinned tabs are positioned. See the spec. It'll also need a label added when the sidebar is in the expanded state.

There's currently a tabs-newtab-button element that's nested in the arrowscrollbox the same as tabbrowser-tabs here and that gets moved when the tabstrip moves, so we can probably repurpose that.

Comment 2

[Sarah Clements [:sclements]]

Attachment: Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=Dao,#sidebar-reviewers

• Create a new container to house pinned tabs, new tab button and non-pinned tabs
• Create new pinned tabs container to apply grid layout and overflow scrolling
• Update test coverage for pinned tabs for both horizontal and vertical tabs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f81bc4882ecc
Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f81bc4882ecc

Comment 7

[tabmix.onemen]

unpinned tab stay in pinned position on vertical sidebar until Firefox restart