1893793 - Message list may be unsorted in unified folder after changing to unthreaded view

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Create a new saved search covering at least two folders.
2. Select "Sort by" -> "Unthreaded".

Expected result:
The message list appears unthreaded and sorted by the current sort order.

Actual result:
The message list appears unthreaded and unsorted.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

As soon as another sort order is chosen in that saved search the bug seems to be gone, so apparently a set secondary sort makes a difference:

Setting the view flags issues a resort in DBViewWrapper which isn't performed by nsMsgDBView if a secondary sort isn't set yet. This is only visible when changing to unthreaded, since rebuilding the view threaded or grouped automatically ensures the right order. So the resort invoked by DBViewWrapper isn't only unnecessary in theses case, it also leads to rebuilding the view for a second time.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1893793 - Fix setting view flags for cross-folder/synthetic search views. r=#thunderbird-reviewers

Resorting the messages is only necessary when changing from threaded or grouped to unthreaded.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f1893dbe22c4
Fix setting view flags for cross-folder/synthetic search views. r=mkmelin