1894896 - Changing sort in grouped-by unified folders doesn't work properly

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Create a unified folder (threaded, sorted by date).
2. Sort by correspondents.
3. Sort by grouped-by-sort.
4. Click on "Correspondents" to reverse the sort order.

Expected result:
Sort order is reversed, view keeps grouped-by-sort.

Actual result:
View reverts to unthreaded sorted by date, while the "Correspondents" headers keeps the sort indicator.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Regression window

Comment 2

[John Bieling (:TbSync)]

I am sorry that we find so many regressions which are caused by moving from columnType to columnId. I tried to do test-driven-development, and it looks like a lot of behavior was not properly tested before. Thanks for your work on this, Hartmut.

Comment 3

[Hartmut Welpmann [:welpy-cw]]

No worries, DBViewWrapper is just a quite convoluted piece of code we need to untangle in my opinion. I'll see what I can do!

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1894896 - Fix problems regarding Grouped By Sort views. r=john.bieling

This fixes the following issues:

• Selecting Grouped By Sort in a unified folder doesn't work properly under certain circumstances.
• In a single-folder view with bySize as the secondary sort, selecting Grouped By Sort always uses byDate as the sort type.
• In a multi-folder view with bySize as the primary sort, selecting Grouped By Sort destroys the view.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97d52c514471
Fix problems regarding Grouped By Sort views. r=john.bieling