1894013 - After restart, the names and icons of the reordered top sites are mismatched (if placed after the 'Add Shortcut)

Status: NEW

(Firefox :: New Tab Page, defect, P2)

Description

[Brindusa Tot, DTE]

Attachment: Screen Shot 2024-04-29 at 5.04.48 PM.png

Found in

• Beta 125.0b6

Affected versions

• Nightly 127 and Beta 126, Nightly 125

Unaffected versions

• Release 125

Tested platforms

• Affected platforms: All
• Unaffected platforms:

Preconditions
*Strat Firefox with a new profile

Steps to reproduce

1. Open a new tab.
2. On topsite area, using drag and drop reorder the default topsites in a different order and make sure "Add Shorcut" is in the middle.
3. Close the browser
4. Start the browser and observe the top sites order

Expected result

• The top sites order should be the same as the one before restart.

Actual result

• After restart, the name and the icon for topsites after the "Add Shorcut" does not match.

Regression range

• Looking for regression range asap

Additional notes

• On a new tab, the order is the correct one. Also, with a refresh/reload of the page the order is correct.

Comment 1

[Donal Meehan [:dmeehan]]

Brindua, any luck with a regression range here?

:jteow, could this be triaged for priority/severtity? We are in the final week of beta for Fx126.

Comment 2

[Brindusa Tot, DTE]

Unfortunately did not work with mozregression and I tried to get manual the regression range. Find out that the
Last good - build from Mar 02 with build id: 20240302101852 - https://archive.mozilla.org/pub/firefox/nightly/2024/03/2024-03-02-10-18-52-mozilla-central/,

First bad - build from Mar 02 with build id: 20240302215519 - https://archive.mozilla.org/pub/firefox/nightly/2024/03/2024-03-02-21-55-19-mozilla-central/ with push og: https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=8b7beaff4b9647b085c7b169353400a0d8b38cde

From the long list of bugs, possible regressior is bug 1877465

Comment 3

[James Teow [:jteow]]

Attachment: Screenshot 2024-04-30 at 10.57.09 AM

I've been able to reproduce the issue on Firefox 115.

I also noticed the add Shortcut Button can appear more than once. And this doesn't just happen with default top sites, a custom added top site can cause the same issue.

Refreshing the page does indeed fix the dupe Add Shortcut issue and the wrong tile title issue.

It's worth noting the Top Sites listing in the address bar is as expected, so this could potentially be more of a New Tab specific implementation issue than an issue with Top Sites itself.

Comment 4

[James Teow [:jteow]]

I'm going to move this over to New Tab because based on the address bar and fresh new tab correctly showing the data it seems like the Top Sites data is working, it's just the presentation of Top Sites data is very out of sync.

Comment 5

[Nathan Barrett [:nbarrett]]

Yeah, this is a newtab issue and a regression from 877465, thank you

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Noting in triage, since this is a fairly recent regression, if we do end up with a fix it is probably worth requesting (or considering) uplift.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1877465