1894512 - [toolbar redesign] Implement long press tab tray button

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Roger Yang [:royang]]

Implement the same behaviour as the current toolbar when user long press on the tab tray button.
Figma

Comment 1

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Beta experiment blockers to priority P2 until we finish fixing our Nightly blockers.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1894512 - Add an AndroidView composable that supports properly positioning a menu r=#android-reviewers

A fully Compose implementation that would use a DropdownMenu would not allow positioning
the menu to the bottom of the screen because DropdownMenu use hardcoded margins and paddings.
Following community requests this shortcoming is to be fixed in
https://github.com/JetBrains/compose-multiplatform/issues/1878 after which we can migrate
to a fully Compose implementation.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1894512 - Have navbar use ToolbarTabCounterButton and FenixTabCounterMenu r=#android-reviewers

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1894512 - Add new telemetry for the new long tapped event on the tabs tray button r=#android-reviewers

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Current behavior with the address bar

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: New behavior for the nav bar

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: FloatingTabsCounterMenu.png

Showing what using app's ContextualMenu or Compose's DropdownMenu would give us: a menu opened very high up from the toolbar button, so much so that the relation between the two may be lost and would get to be an ugly visual bug.
This happens because Compose hardcodes a margin and padding to ensure menus do not appear right to the edge of the screen even though that is what we need/want.
Fortunately by popular request this is considered to be fixed - https://github.com/JetBrains/compose-multiplatform/issues/1878 and after this change we'll be able to go with a full Compose implementation.

Comment 8

[Aarjav [:aarjav]]

UX approved

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64d8e75c61fa
Add an AndroidView composable that supports properly positioning a menu r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/8e3ded3d44c5
Have navbar use ToolbarTabCounterButton and FenixTabCounterMenu r=android-reviewers,mobiletest-reviewers,ohorvath,gl
https://hg.mozilla.org/integration/autoland/rev/9332e4041b45
Add new telemetry for the new long tapped event on the tabs tray button r=android-reviewers,mobiletest-reviewers,ohorvath,gl

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/64d8e75c61fa
https://hg.mozilla.org/mozilla-central/rev/8e3ded3d44c5
https://hg.mozilla.org/mozilla-central/rev/9332e4041b45

Comment 11

[Lorand Janos]

Verified as fixed on the latest Nightly and an earlier (129 cycle one to confirm on the version where the fix was made) Nightly builds (129.0a1 and 130.0a1 from 2024-07-12). with Navigation Toolbar enabled from Secret Settings on 129.

Devices used:

• Samsung Galaxy S23 Ultra (Android 14).
• Samsung Galaxy Fold 5 (android 14).
• Google Pixel 7 (Android 15 Beta 3).

Marking the ticket as verified on 129 and 130.

Comment 12

[Lorand Janos]

Attachment: Edited_Recorder_12072024_174332.mp4