1907484 - Fenix URLbar context-menu is same color as the toolbar that it appears over, when in private browsing mode

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P1)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

Steps to reproduce

1. Open a Private Browsing tab and visit some site, e.g. https://example.org/
2. Long-press the URL bar, to trigger a context-menu to open.

Expected behavior

Context menu should be easy to distinguish over the UI that it overlaps.

Actual behavior

Context menu is the same color purple as the UI that it overlaps (the newly-introduced nav bar)

Device information

• Firefox version: 130.0a1 2024-07-11
• Android device model: Pixel 8
• Android OS version: 14

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of dark-theme regular browsing mode (not private browsing), for comparison

When not in private-browsing mode, the contrast is much better between this context-menu and the UI behind it, as shown here.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of light-theme regular browsing mode, for comparison

Actually, with the light theme, the context-menu has the same sort of issue, sort of -- it's the same color as the UI that it covers up, but the shadows are at least easier to see so that you can distinguish it.

Whereas in private browsing mode, the shadows are a bit harder to make out (since they're dark shadows on dark purple).

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902798

:mavduevskiy, since you are the author of the regressor, bug 1902798, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

As described by Daniel in c#2 this was already an issue for the light theme also and I'd argue it was already an issue for the private theme also.
The text can be clearly read but there is less/no contrast between app's dialogs and the other window elements.
I think this is by design and we wanted ensure popups and the rest of app's chrome have the same color
And the only regression here is that the bottom toolbar now has a bigger height that allows the contextual menu to automatically be placed below the address bar while previously it was placed above.

I propose then to only focus on ensuring that when the toolbar is at the bottom this contextual menu is shown above the address bar (Y axis).
Whether we want to have more contrast between this menu and the rest of the app's window elements is a bigger discussion.

Comment 5

[Aarjav [:aarjav]]

I agree with this approach. "I propose then to only focus on ensuring that when the toolbar is at the bottom this contextual menu is shown above the address bar (Y axis)."

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to Petru-Mugurel Lingurar [:petru] from comment #4)

I propose then to only focus on ensuring that when the toolbar is at the bottom this contextual menu is shown above the address bar (Y axis).

That sounds good to me too. That restores the prior behavior here.

Comment 7

[[:skhan]]

Attachment: Bug 1907484 - Update context-menu vertical offset for bottom toolbar

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36fd23486e9b
Update context-menu vertical offset for bottom toolbar r=android-reviewers,tchoh

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/36fd23486e9b