1894538 - DLP timeout is not enforced by Firefox

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Greg Stoll :gstoll]

The browser.contentanalysis.agent_timeout pref (and corresponding enterprise policy) are used to set the expires_at field on ContentAnalysisRequest. However, Firefox does not enforce this timeout. Firefox should probably cancel the request after the timeout expires (or, to be more precise, handle it like we do when the user cancels and just stop blocking the UI)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:handyman, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[David Parks [:handyman]]

This is higher priority than most DLP issues and is borderline S2. This should be addressed soon.

Comment 3

[David Parks [:handyman]]

Just to add to comment 0, we hadn't been sending cancel to the agent but we do now (since bug 1926362).

Comment 4

[David Parks [:handyman]]

Attachment: Bug 1894538: Part 1 - Repair autoAcknowledge implementation in content analysis r=#dlp-reviewers!

Auto-acknowledge has not been responding properly in the case of cancelled
events. In fact, it usually wouldn't acknowledge responses to cancelled
requests at all. And it never reported that the response was TOO_LATE.
This patch removes autoAcknowledge from the user action data and passes it
through the request-response-acknowledge cycle for each request, since it
is really a property of requests/responses and must persist beyond the user
action (as long as there is an outstanding request that the agent hasn't
responded to). The patch also adds UserActionIdToToCanceledResponseMap, so
that we can respond to the agent with the result we used when we cancelled,
which is based on prefs.

Depends on D237659

Comment 5

[David Parks [:handyman]]

Attachment: Bug 1894538: Part 2 - Cancel content analysis requests on timeout r=#dlp-reviewers!

Depends on D237660

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa65062f3ac4
Part 1 - Repair autoAcknowledge implementation in content analysis r=dlp-reviewers,gstoll
https://hg.mozilla.org/integration/autoland/rev/c443aa2bdf07
Part 2 - Cancel content analysis requests on timeout r=dlp-reviewers,fluent-reviewers,flod,gstoll
https://hg.mozilla.org/integration/autoland/rev/1dd1c3328a45
apply code formatting via Lando

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fa65062f3ac4
https://hg.mozilla.org/mozilla-central/rev/c443aa2bdf07
https://hg.mozilla.org/mozilla-central/rev/1dd1c3328a45

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified with Firefox 137.0a1 (2025-02-19) on Windows 10x64 by using the test cases (C2928447/ (C2928449/ C2928450) approved by engineering.