1944395 - Add separate default actions for when Content Analysis times out versus hits an error

Status: RESOLVED FIXED

(Firefox :: Data Loss Prevention, task)

Description

[Greg Stoll :gstoll]

(also requires enterprise policies)

Comment 1

[Greg Stoll :gstoll]

Attachment: Bug 1944395 part 1 - add Content Analysis pref for result to return if the agent times out r=#dlp-reviewers!

Also add a gtest for the default result pref, which I don't think we
had anywhere.

Comment 2

[Greg Stoll :gstoll]

Attachment: Bug 1944395 part 2 - drive-by cleanup of GetDiagnosticInfo() logic r=#dlp-reviewers!

When I added some gtests in part 1 this caused a gtest to fail. The
problem was that GetDiagnosticInfo() was looking at the last result
to determine whether we are connected to a client. The
CallClientWithRetry() logic now handles this more accurately, so if
we succeed there just set mConnectedToAgent to true.

Comment 3

[Greg Stoll :gstoll]

Attachment: Bug 1944395 part 3 - add Enterprise Policy for timeout result pref r=#dlp-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/978a727e750b
part 1 - add Content Analysis pref for result to return if the agent times out r=dlp-reviewers,handyman
https://hg.mozilla.org/integration/autoland/rev/0303076bb6d8
part 2 - drive-by cleanup of GetDiagnosticInfo() logic r=dlp-reviewers,handyman
https://hg.mozilla.org/integration/autoland/rev/42e5e0d2a332
part 3 - add Enterprise Policy for timeout result pref r=dlp-reviewers,handyman

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/978a727e750b
https://hg.mozilla.org/mozilla-central/rev/0303076bb6d8
https://hg.mozilla.org/mozilla-central/rev/42e5e0d2a332