1895228 - Consider removing apz.windows.use_direct_manipulation pref

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P5)

Description

[Gregory Pappas [:gregp]]

Right now, there are two prefs for disabling Direct Manipulation:

• apz.windows.use_direct_manipulation (added in bug 1630912, enabled in bug 1671235)
• apz.windows.force_disable_direct_manipulation (added in bug 1632357, disabled in bug 1643634)

Are both necessary?

Comment 1

[Botond Ballo [:botond]]

cc Timothy for an opinion on this

Comment 2

[Timothy Nikkel (:tnikkel)]

I believe the main purpose of apz.windows.force_disable_direct_manipulation was to disable the use of the window style flags WS_EX_LAYERED | WS_EX_TRANSPARENT. These flags were necessary for dmanip to function with our window (hwnd) setup, but on some machines they caused blank windows. We fixed the blank window bug but I guess I was being cautious because the severity (drawing blank windows) if we didn't fully fix the issue.

Comment 3

[Daniel Singer]

Hi There,
I'm a new contributer and will have a patch for this shortly.

Tx,
Ds

Comment 4

[Daniel Singer]

Attachment: Bug 1895228 - Removed apz.windows.use_direct_manipulation pref. r?gregp!

Comment 5

[Daniel Singer]

Hi Gregory,

Please see the link below for this WIP patch. I made the following changes:

• Removed apz.windows.use_direct_manipulation pref from modules/libpref/init/StaticPrefList.yaml
• Updated the text in widget/windows/docs/windows-pointing-device/index.rst accordingly

https://phabricator.services.mozilla.com/D271305

Please let me know of any amendments I need to make or which tests I need to run before officially submitting for review.

Tx,
Ds

Comment 6

[Gregory Pappas [:gregp]]

Your patch needs to remove the actual usage in C++, then it will be ready for review.
https://searchfox.org/firefox-main/rev/88121de0ccd1a6e364645b9971f36c5eb00f4317/widget/windows/nsWindow.cpp#961

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1ca9f9e85c02
https://hg.mozilla.org/integration/autoland/rev/9aaabccda3f2
Removed apz.windows.use_direct_manipulation pref. r=win-reviewers,handyman

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9aaabccda3f2