1630912 - land initial preffed off implementation of direct manipulation

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1630912. Add a simple way to observe vsync on the mainthread. r=jrmuizel

Mostly kats' work from https://github.com/staktrace/gecko/commit/241a8b7d30533a6024a92b3adb31497586cce45d

So kats please direct review to someone as appropriate.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1630912. Add PT_TOUCHPAD to touchinjection_sdk80.h. r?aklotz

I have no idea why I need to do this. Let me know if there is a better way.

Depends on D71303

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1630912. Create the necessary direct manipulation objects. r?aklotz

Depends on D71304

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1630912. Hook up direct manipulation object to vsync. r=kats

Depends on D71305

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1630912. Add a small state machine and code to send pinch and pan events from direct manipulation. r=kats

We can't just get pinch events, we need to handle both.

This state machine code is basically copied from Chrome's implementation.

Depends on D71306

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1630912. Handle sending Direct Manipulation input events properly. r?kats

The old code didn't handle content prevent defaulting the input.

The pinch gesture code doesn't seem to fully work properly, it will allow a little pinch zooming before halting it if content is prevent defaulting it. Not sure what is up yet.

Depends on D71307

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6cd2ceab183
Add a simple way to observe vsync on the mainthread. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f7d9852a3d09
Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/e202ddeb4e40
Create the necessary direct manipulation objects. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/108b1a07929b
Hook up direct manipulation object to vsync. r=kats
https://hg.mozilla.org/integration/autoland/rev/08a6a1f1c4c7
Add a small state machine and code to send pinch and pan events from direct manipulation. r=kats
https://hg.mozilla.org/integration/autoland/rev/21dc02bc12b9
Handle sending Direct Manipulation input events properly. r=kats

Comment 8

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=21dc02bc12b9e9a938eda42271eea3c4841f3346&selectedTaskRun=KHkDsHVYTXyK6ywPOjuCdQ-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300820550&repo=autoland&lineNumber=29754

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300821951&repo=autoland&lineNumber=341566

Backout: https://hg.mozilla.org/integration/autoland/rev/68ab42d205e5d0746fba7ad9cd5a7e19287ac872

Comment 9

[Kartikaya Gupta (email:[e-mail])]

This also caused bug 1635349, gtest failure on macOS

Comment 10

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1630912. DManipEventHandler needs threadsafe refcount because Windows touches it off main thread. r?aklotz

I guess I only tested in non-debug builds until now, here's stack I got.

Hit MOZ_CRASH(DManipEventHandler not thread-safe) at c:/mozilla/src/xpcom/base/nsISupportsImpl.cpp:40
#01: mozilla::widget::DManipEventHandler::QueryInterface (c:\mozilla\src\widget\windows\DirectManipulationOwner.cpp:0)
#02: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x4f708]
#03: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x4fae4]
#04: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x49d0d]
#05: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x481a8]
#06: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x4912b]
#07: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x5823f]
#08: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x57fb7]
#09: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x58872]
#10: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x57df0]
#11: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x57d53]
#12: DllGetActivationFactory[C:\WINDOWS\system32\directmanipulation.dll +0x5410e]
#13: InitializeDManipHook[C:\WINDOWS\system32\directmanipulation.dll +0x37645]
#14: ???[C:\WINDOWS\system32\directmanipulation.dll +0x1e754]
#15: BaseThreadInitThunk[C:\WINDOWS\System32\KERNEL32.DLL +0x17bd4]
#16: RtlUserThreadStart[C:\WINDOWS\SYSTEM32\ntdll.dll +0x6ce51]

Do I need to change anything else or is this enough?

Depends on D73220

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9f85e3ccde7
Add a simple way to observe vsync on the mainthread. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/b1bd509220e9
Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/321438a68aab
Create the necessary direct manipulation objects. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/05015d1e8315
Hook up direct manipulation object to vsync. r=kats
https://hg.mozilla.org/integration/autoland/rev/c6a3a55f67a1
Add a small state machine and code to send pinch and pan events from direct manipulation. r=kats
https://hg.mozilla.org/integration/autoland/rev/93ab81106303
Handle sending Direct Manipulation input events properly. r=kats

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f9f85e3ccde7
https://hg.mozilla.org/mozilla-central/rev/b1bd509220e9
https://hg.mozilla.org/mozilla-central/rev/321438a68aab
https://hg.mozilla.org/mozilla-central/rev/05015d1e8315
https://hg.mozilla.org/mozilla-central/rev/c6a3a55f67a1
https://hg.mozilla.org/mozilla-central/rev/93ab81106303