1895748 - [toolbar redesign] Revert toolbar redesign changes from old toolbar component

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P1)

Description

[Roger Yang [:royang]]

After refactor, remove toolbar redesign changes from the original toolbar.

Comment 1

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Nightly blockers to priority P1.

Comment 2

[Roger Yang [:royang]]

Attachment: Bug 1895748 - Remove toolbar redesign changes from original toolbar component

Comment 3

[Roger Yang [:royang]]

Attachment: Bug 1895748 - Remove toolbar layout changes not needed for nav bar release.

Comment 4

[Mike a [:mavduevskiy]]

Some additional context

That's the list of commits in question
04ef01d2c8ed17c80aeb93fbf8070f8939314bf3 // need to test
c5be57c802891c2098d05fc5b0fbc0d1f4b70aeb // for l10n
e13643e1ce539d3523c4d41b9f21aeea2653e70c // revert
9038390a7f935eeff0f0c333e6e78f964c14f660 // reordering, don't revert
b2e5a1ad5d951b645d54ee2de2f5e2557290aea2 // don't need to revert
fa86d2d1206beafb07bc998078d3da67b59e4577 // we probably need? Padding
f34e1ba2d96137299b439edcccbdcbbcc460a8e9 // fix conflict
d57d64ae55a557f3a9d7640f359545e3979c0ce9 // manual
883ea4e6646a6e46caeee69991aacfb3f0050d2a // probably not
c337ce570e398de11de750bfb3ac27726e104013 // don't need to revert

QR buttons we removed from the home page because of issues with animation (a guess – when search bar was opened, buttons would reanimate).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e4dbff359c5
Remove toolbar layout changes not needed for nav bar release. r=android-reviewers,harrisono,skhan,tchoh,mavduevskiy

Comment 6

[Cristian Tuns]

Backed out for causing failures in BrowserToolbarTest.kt

• Backout link
• Push with failures
• Failure Log
• Failure line: file:///builds/worker/checkouts/gecko/mobile/android/android-components/components/browser/toolbar2/src/test/java/mozilla/components/browser/toolbar2/BrowserToolbarTest.kt:578:17: error: Unresolved reference: showPageActionSeparator

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c8b78125244
Remove toolbar layout changes not needed for nav bar release. r=android-reviewers,harrisono,skhan,tchoh,mavduevskiy

Comment 8

[Roger Yang [:royang]]

Fixed and relanded the change. Thanks

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5c8b78125244