1895755 - Support different minHeight values for CTA buttons

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Shane Hughes [:aminomancer]]

Right now, CTAs in feature callouts are all stuck at min-height: 32px, which limits our ability to create mini callouts. paddingBlock is configurable but that doesn't help if the min-height is too small. So, we need to make minHeight configurable also.

Comment 1

[Shane Hughes [:aminomancer]]

We should resolve this since it leads to a discrepancy with designs. It should be pretty quick and easy.

Comment 2

[Shane Hughes [:aminomancer]]

Bug 1873524 is a related bug to add a single property that can set multiple CSS properties to automatically align with the mini callout template, which is now used in most feature callout designs. That includes the button height/padding, the callout padding, and the arrow height, and possibly more if you check the figma. So after doing this one, it may be worth doing the other also.

Comment 3

[Mimi Jung]

Setting this as a P2 for now in favor of higher priority rootCa desktop and android messaging.

Comment 4

[Mimi Jung]

Setting this to a P1 as we have quite a few designs with smaller CTAs.

Comment 5

[Mimi Jung]

Attachment: Bug 1895755 - Updates default min-height for feature callout ctas to 24px

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce10d40bff63
Updates default min-height for feature callout ctas to 24px r=omc-reviewers,aminomancer

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ce10d40bff63