1895981 - Disable confirm button for "turn on scheduled backups" dialog if encryption is required and not yet set

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[kpatenio]

The dialog for turning on scheduled backups (see Bug 1893277) allows for encrypting the backup file if users want to back up sensitive data. This ticket is for implementing behaviour to prevent further progress in the dialog if that option is selected and a password has to be set. Users will be able to confirm their choice and enable scheduled backups once the password is made.

We may want to save the password in this bug too by passing the saved input to BackupUIParent.

For the lo-fi Figma design, see https://www.figma.com/file/vNbX4c0ws0L1qr0mxpKvsW/Fx-Backup?node-id=450-11409

Comment 1

[kpatenio]

I just filed Bug 1896772, which will impact all dialogs that enable users to add passwords for a backup file. We may want to pair work for that bug with work for this one.

Comment 2

[kpatenio]

I can make an attempt at this. Although most of the encryption functionality is based on existing work in Bug 1897278, we could add some logic for the dialog that handles:

• validating inputted passwords* before we can press the "Confirm" button
• Passing the inputted password from the dialog to BackupService via actors
• Making BackupService set encryption alongiside the password using enableEncryption after closing the dialog
• Inversely, we might have to call disableEncryption when we turn off scheduled backups via the turn-off-scheduled-backups dialog

*Unlike Bug 1896772, we won't focus on the complete password rules for this bug.

Comment 3

[kpatenio]

Attachment: Bug 1895981 - Allow password setting from turn-on-scheduled-backups dialog. r=#backup-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8103d1ae73d6
allow password setting from turn-on-scheduled-backups dialog r=backup-reviewers,mconley

Comment 5

[Cristian Tuns]

Backed out for causing bc failures in browser_startup_mainthreadio.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected read on D:\task_171808496973085\AppData\Roaming\Microsoft\Windows\Libraries\desktop.ini before becoming idle -

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01ba06d4406f
Allow password setting from turn-on-scheduled-backups dialog. r=backup-reviewers,fchasen

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/01ba06d4406f