1897781 - Changing sort in in threaded unified folder does not set secondary sort

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Create a new saved search covering at least two folders. View should be threaded and sorted by date, all threads collapsed.
2. Sort by subject.
3. Sort by correspondents.
4. Sort by unthreaded.
5. Sort by subject.
6. Sort by correspondents.
7. Sort by threaded.

Expected result:
After step 3, messages with the same correspondent should be sorted by subject.

Actual result:
After step 3, messages with the same correspondent are sorted by order received, which is the default secondary sort type. After step 7 those messages are sorted by subject, but changing the sort again doesn't set the secondary sort.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1897781 - Set secondary sort in threaded cross-folder views. r=john.bieling

Comment 2

[John Bieling (:TbSync)]

Sorry for the delay, will look at it today!

Comment 3

[Toby Pilling]

Hi @welpy-cw Thanks a lot for reporting this and for the patch.

I followed your steps to reproduce on Daily and on my local but wasn't able to recreate the problem - unless I use 115 where I can still experience the issue, given your clear instructions. I spoke to @john.bieling about this and we wondered if you are able to recreate the problem using Daily?

Before we do anything with the patch and test (thanks!), we just wanted to make sure that we haven't missed something in our testing.

Could you perhaps test Daily to see if you have the same problem? We would like to ensure that this issue hasn't already been addressed.

Many thanks

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Hi Toby,

that's really strange.

(In reply to Toby Pilling from comment #3)

I followed your steps to reproduce on Daily and on my local but wasn't able to recreate the problem - unless I use 115 where I can still experience the issue, given your clear instructions. I spoke to @john.bieling about this and we wondered if you are able to recreate the problem using Daily?

Before we do anything with the patch and test (thanks!), we just wanted to make sure that we haven't missed something in our testing.

Could you perhaps test Daily to see if you have the same problem? We would like to ensure that this issue hasn't already been addressed.

I just performed the STR again with the latest local Daily build as well as with 115.11. With both versions I get exactly the same result as described in comment 0.

Comment 5

[Toby Pilling]

Hi Hartmut,
I tested this with John earlier today and the Daily seems to work ok on Windows without this patch. Could you please let us know what OS are you using and if have any add-ons or tweaks that might help us reproduce?
Cheers

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Attachment: Behavior with Daily 128.0a1 (2024-05-28) (Windows 64-bit).mp4

This shows the behavior in a newly created saved search covering two folders. I added the column "Order received", since this is the default secondary sort after creating a cross-folder view.
Clicking on "Subject" followed by clicking on "Correspondents" should set the secondary sort to "Subject", but messages with the same correspondent are still sorted by "Order received".

Comment 7

[Toby Pilling]

Thanks Hartmut, most helpful!
I was able to reproduce the issue when using a saved search with at least two folders inside Local Folders - it works fine when using a saved search on account folders.
I have also verified that your patch fixes the problem.
All the best

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d368bef1772
Set secondary sort in threaded cross-folder views. r=john.bieling,leftmostcat

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9402767 [details]
Bug 1897781 - Set secondary sort in threaded cross-folder views. r=john.bieling

[Approval Request Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 127.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/df3ab42e8de5

Comment 12

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce this issue with the affected build from 2024-05-20 (20240520103238) using Windows 11.

Confirming this issue as verified fixed on 127.0b5(20240603175044) using macOS 14, Windows 11 and Ubuntu 22.