1897924 - Migrating from UI version xx to 43 failed. - exception in OutgoingServerService.sys.mjs :: _keyToServer

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

Started an old profile. Got
console.error: "Migrating from UI version 34 to 43 failed. Error message was: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: resource:///modules/OutgoingServerService.sys.mjs :: _keyToServer :: line 247" data: no] -- Will reattempt on next start."

This seems to be half-intentional - https://searchfox.org/comm-central/rev/9a8e81d16a3de5e97406ac2f769a85a6bf5a87b0/mailnews/compose/src/OutgoingServerService.sys.mjs#244 - but wrong. It will hold up all further migrations.
It should be built just to filter out such cases, not throw.

Comment 1

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1897924 - Default to SMTP if we can't figure out the type of an outgoing server. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3696a5582c30
Default to SMTP if we can't figure out the type of an outgoing server. r=mkmelin

Comment 3

[Brendan Abolivier [:babolivier]]

Comment on attachment 9407971 [details]
Bug 1897924 - Default to SMTP if we can't figure out the type of an outgoing server. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1882574
User impact if declined: Users using Thunderbird with a profile which version is 35 (introduced in bug 1798875) or below, will encounter an error on startup, and their profile won't be updated above version 35, possibly causing incompatibilities with more recent versions of Thunderbird.
Testing completed (on c-c, etc.): On c-c
Risk to taking this patch (and alternatives if risky): Low, patch is small and comes with a unit test

Comment 4

[Corey Bryant]

Comment on attachment 9407971 [details]
Bug 1897924 - Default to SMTP if we can't figure out the type of an outgoing server. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Brendan Abolivier [:babolivier]]

Corey, shouldn't the target milestone be 128 (not 129)? The current beta is 128 and the aim is to include this fix in ESR 128.

Comment 6

[Alessandro Castellani [:aleca]]

Nope, code that lands on trunk always needs to be represented in the correct milestone it lands in.
Right now we're in the 129 alpha (daily) cycle.
In order to get it to 128 Corey correctly approved it for comm-beta uplift in comment 4.

Comment 7

[Brendan Abolivier [:babolivier]]

Gotcha, thanks Alex. Looks like the timings of the actions got me confused.

Comment 8

[Corey Bryant]

I can see the confusion with the timing. Thank you both for keeping an eye on things!

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1c3bece2628b