1898492 - Filter in-app notifications based on their criteria

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Martin Giger [:freaktechnik]]

The in-app notifications returned by the server have a section of conditions for clients the notification should be shown in. The current implementation already uses the start/end dates provided, but all other conditions are currently not used. getNotifications should only return notifications that are to be shown in the current client.

There is a random field to only target a percentage of the user population. This should probably roll and then save the result per notification, so we don't show every notification if you just try often enough.

The other conditions should be fairly straight forward to handle with AppConstants.sys.mjs (& friends) and some array methods.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1898492 - Add notification filtering for in-app notifications. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/651c2f89f31e
Add notification filtering for in-app notifications. r=aleca

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9408008 [details]
Bug 1898492 - Add notification filtering for in-app notifications. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: (feature wanted in a point release)
Testing completed (on c-c, etc.): Fully covered by automated tests.
Risk to taking this patch (and alternatives if risky): Low risk, feature completely disabled.

Comment 4

[Corey Bryant]

Comment on attachment 9408008 [details]
Bug 1898492 - Add notification filtering for in-app notifications. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a92c1b782e4f