Closed Bug 1899167 Opened 8 months ago Closed 8 months ago

"Attach the source of this link to the message" is always unchecked when opening "Link Properties"

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Version:
Thunderbird 128
Type:
defect

Tracking

(thunderbird_esr115 unaffected)

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
thunderbird_esr115 --- unaffected

People

(Reporter: welpy-cw, Assigned: welpy-cw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1899167 - Fix the order deferred scripts are loaded in EdLinkProps.xhtml. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
Details | Review
With patch applied.mp4
276.98 KB, video/mp4
Details

Steps to reproduce:

  1. Compose a new HTML message.
  2. Insert a link, such as "https://bugzilla.mozilla.org/show_bug.cgi?id=1787143", with "Attach the source of this link to the message" unchecked.
  3. Save the message as draft.
  4. View the message source.

Expected result:
The draft message consists only of some HTML containing the inserted link.

Actual result:
Console shows

Uncaught TypeError: can't access property "value", gMsgCompInputElement is undefined
    OnAcceptDialog chrome://messenger/content/messengercompose/EdImageLinkLoader.js:50
    _fireButtonEvent chrome://global/content/elements/dialog.js:515
    _doButtonCommand chrome://global/content/elements/dialog.js:494
    _handleButtonCommand chrome://global/content/elements/dialog.js:488
    doCommand chrome://messenger/content/messengercompose/ComposerCommands.js:1487
    goDoCommand chrome://messenger/content/globalOverlay.js:99
    oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1

after step 2. The draft message contains additionally a base64-encoded part with the source of the link.

Assignee: nobody → h.w.forms
Status: NEW → ASSIGNED
See Also: → 1787143

Thanks for the report, but unfortunately I'm not able to reproduce this issue.
My saved draft message only contains this HTML:

<!DOCTYPE html>
<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1899167">Link</a><br>
    </p>
    <div class="moz-signature">-- <br>
      <div style="font-size:0.9rem"> <b>Alessandro Castellani</b> <i
          style="opacity:0.9">(he, him) [@aleca]</i><br>
        Director, Desktop and Mobile Apps<br>
        <a href="https://www.thunderbird.net" rel="nofollow"
          target="_blank">Thunderbird</a>
      </div>
    </div>
  </body>
</html>

(In reply to Hartmut Welpmann [:welpy-cw] from comment #0)

after step 2. The draft message contains additionally a base64-encoded part with the source of the link.

Can you share your saved draft in EML format?
Do you have any add-ons?
Do you have "Enable encryption for new messages" checked?

Flags: needinfo?(h.w.forms)

Apologies, I actually cannot reproduce the main issue anymore either. But I do get the mentioned error in the console every time the "Link Properties" dialog is closed, while "Attach the source of this link to the message" is always unchecked when that dialog opens after double-clicking a previously added link, regardless of the selected choice before. This seems to be a regression from 115, presumably from bug 1703164.

Fortunately this makes the issue significantly less severe than I initially thought.

Severity: S3 → S4
Flags: needinfo?(h.w.forms)
Keywords: regression
Regressed by: 1703164
Summary: When inserting a link, the source of the link is always attached to the message → "Attach the source of this link to the message" is always unchecked when opening "Link Properties"

No worries, it happens.
Is the current patch still relevant and fixes the issue of the checkbox status?
Would you be able to also fix the JS error triggered when closing the link properties dialog?

(In reply to Alessandro Castellani [:aleca] from comment #4)

No worries, it happens.
Is the current patch still relevant and fixes the issue of the checkbox status?
Would you be able to also fix the JS error triggered when closing the link properties dialog?

Yes, this should fix both these issues!

Actually, I think that checkbox should not exist for links. If you have a document you want attached, just add it as a normal attachment.
It's supposed to be there for images so that you can choose to have remote image included or not.

Attached video With patch applied.mp4 —

This is the behavior in Daily under Linux with the patch from comment 1 applied.

I also see this corrected behaviour when testing the patch on Windows

It's easily reproducible for me on linux. (And the patch fixes it.)

Keywords: checkin-needed-tb
Target Milestone: --- → 128 Branch

Pushed by solange@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/b023051a69e4
Fix the order deferred scripts are loaded in EdLinkProps.xhtml. r=mkmelin,aleca

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
See Also: → 1899710
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: