"Attach the source of this link to the message" is always unchecked when opening "Link Properties"
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(thunderbird_esr115 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr115 | --- | unaffected |
People
(Reporter: welpy-cw, Assigned: welpy-cw)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Steps to reproduce:
- Compose a new HTML message.
- Insert a link, such as "https://bugzilla.mozilla.org/show_bug.cgi?id=1787143", with "Attach the source of this link to the message" unchecked.
- Save the message as draft.
- View the message source.
Expected result:
The draft message consists only of some HTML containing the inserted link.
Actual result:
Console shows
Uncaught TypeError: can't access property "value", gMsgCompInputElement is undefined
OnAcceptDialog chrome://messenger/content/messengercompose/EdImageLinkLoader.js:50
_fireButtonEvent chrome://global/content/elements/dialog.js:515
_doButtonCommand chrome://global/content/elements/dialog.js:494
_handleButtonCommand chrome://global/content/elements/dialog.js:488
doCommand chrome://messenger/content/messengercompose/ComposerCommands.js:1487
goDoCommand chrome://messenger/content/globalOverlay.js:99
oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1
after step 2. The draft message contains additionally a base64-encoded part with the source of the link.
|
Assignee | |
Comment 1•3 months ago
|
||
|
||
Updated•3 months ago
|
|
||
Comment 2•3 months ago
|
||
Thanks for the report, but unfortunately I'm not able to reproduce this issue.
My saved draft message only contains this HTML:
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p><a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1899167">Link</a><br>
</p>
<div class="moz-signature">-- <br>
<div style="font-size:0.9rem"> <b>Alessandro Castellani</b> <i
style="opacity:0.9">(he, him) [@aleca]</i><br>
Director, Desktop and Mobile Apps<br>
<a href="https://www.thunderbird.net" rel="nofollow"
target="_blank">Thunderbird</a>
</div>
</div>
</body>
</html>
(In reply to Hartmut Welpmann [:welpy-cw] from comment #0)
after step 2. The draft message contains additionally a base64-encoded part with the source of the link.
Can you share your saved draft in EML format?
Do you have any add-ons?
Do you have "Enable encryption for new messages" checked?
|
|
Assignee | |
Comment 3•3 months ago
|
||
Apologies, I actually cannot reproduce the main issue anymore either. But I do get the mentioned error in the console every time the "Link Properties" dialog is closed, while "Attach the source of this link to the message" is always unchecked when that dialog opens after double-clicking a previously added link, regardless of the selected choice before. This seems to be a regression from 115, presumably from bug 1703164.
Fortunately this makes the issue significantly less severe than I initially thought.
|
|
Assignee | |
Updated•3 months ago
|
|
|
||
Comment 4•3 months ago
|
||
No worries, it happens.
Is the current patch still relevant and fixes the issue of the checkbox status?
Would you be able to also fix the JS error triggered when closing the link properties dialog?
|
|
Assignee | |
Comment 5•3 months ago
|
||
(In reply to Alessandro Castellani [:aleca] from comment #4)
No worries, it happens.
Is the current patch still relevant and fixes the issue of the checkbox status?
Would you be able to also fix the JS error triggered when closing the link properties dialog?
Yes, this should fix both these issues!
|
||
Comment 6•3 months ago
|
||
Actually, I think that checkbox should not exist for links. If you have a document you want attached, just add it as a normal attachment.
It's supposed to be there for images so that you can choose to have remote image included or not.
|
|
Assignee | |
Comment 7•3 months ago
|
||
This is the behavior in Daily under Linux with the patch from comment 1 applied.
|
|
Assignee | |
Updated•3 months ago
|
|
||
Comment 10•3 months ago
|
||
Pushed by solange@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/b023051a69e4
Fix the order deferred scripts are loaded in EdLinkProps.xhtml. r=mkmelin,aleca
Description
•