1899348 - [DNR] Remove MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES

Status: NEW

(WebExtensions :: Request Handling, task, P3)

Description

[Rob Wu [:robwu]]

In bug 1894128, the MAX_NUMBER_OF_SESSION_RULES and MAX_NUMBER_OF_DYNAMIC_RULES constants were introduced to supersede MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES.

We should remove the old MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES. The only reason for having it was for compatibility with Chrome, which had the constant to define the limit on the combined number of dynamic + session rules. Firefox has always treated this as the separate limits of dynamic and session rules, and Chrome has followed this implementation since then. The MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES constant is now undocumented in Chrome and should not be used.
Safari is also willing to drop the MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES constant.

The impact of dropping this would be minimal. There are only a few extensions that reference this constant in their source, and only one extension with 3 users would have a logical change in behavior if the constant were to be dropped. Here are all public AMO extensions with the declarativeNetRequest or declarativeNetRequestWithHostAccess permission that contain MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES in their source. The number at the front is the number of users.

• uBlock Origin Lite and forks - not critical - logging only: https://github.com/uBlockOrigin/uBOL-home/blob/uBOLite_2024.5.27.852/firefox/js/ruleset-manager.js#L69

  • 4105 https://addons.mozilla.org/en-US/firefox/addon/ublock-origin-lite/
  • 1514 https://addons.mozilla.org/en-US/firefox/addon/lock-adblock/
  • 883 https://addons.mozilla.org/en-US/firefox/addon/1block/
  • 22 https://addons.mozilla.org/en-US/firefox/addon/adblocking/

• tracklessURL - calling updateDynamicRules when numDynamicRules < browser.declarativeNetRequest.MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES

  • 3 https://addons.mozilla.org/en-US/firefox/addon/tracklessurl/

• Contains "MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES" in a code comment only.

  • 1 https://addons.mozilla.org/en-US/firefox/addon/ql/