[DNR] Replace MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES
Categories
(WebExtensions :: Request Handling, task, P2)
Tracking
(firefox128 fixed)
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: robwu, Assigned: rpl)
References
(Blocks 3 open bugs)
Details
(Keywords: dev-doc-needed, Whiteboard: [wecg][addons-jira])
Attachments
(1 file)
Chrome initially had a shared quota between dynamic and session rules at 5k (DNR constant: MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES). We had separate quotas from the start, but supported the constant for compatibility. Now Chrome has dropped MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES from their documentation because it has been superseded by four separate constants in https://issues.chromium.org/issues/40282671 . Besides the separation of dynamic/session (which Firefox already has), Chrome also introduces the distinction between "safe" and "unsafe" rules.
The purpose of this bug is to make sure that the following happens:
-
introducing the following constants to the declarativeNetRequest namespace:
- MAX_NUMBER_OF_SESSION_RULES (5000)
- MAX_NUMBER_OF_UNSAFE_DYNAMIC_RULES (5000)
- MAX_NUMBER_OF_UNSAFE_SESSION_RULES (5000)
- MAX_NUMBER_OF_DYNAMIC_RULES (5000 initially, ultimately 30000 as part of bug 1894119)
-
introduce the concept of safe rules, as described at https://github.com/w3c/webextensions/issues/319#issuecomment-1682073791
- note: if we start with MAX_NUMBER_OF_DYNAMIC_RULES = 5000 (equal to MAX_NUMBER_OF_UNSAFE_DYNAMIC_RULES), then we could defer this part to bug 1894119.
-
bumping the actual dynamic rule limit, which is part of bug 1894119
|
||
Updated•2 months ago
|
|
Assignee | |
Updated•2 months ago
|
|
|
Assignee | |
Comment 1•1 month ago
|
||
|
||
Updated•1 month ago
|
|
Reporter | |
Comment 2•1 month ago
|
||
The patch in this bug only adds MAX_NUMBER_OF_DYNAMIC_RULES and MAX_NUMBER_OF_UNSAFE_SESSION_RULES instead of MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES. The removal of MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES will happen in a separate bug.
The MAX_NUMBER_OF_UNSAFE_DYNAMIC_RULES and MAX_NUMBER_OF_UNSAFE_SESSION_RULES constants will be covered in bug 1894119.
|
|
Assignee | |
Updated•1 month ago
|
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/457cd5c565fb [DNR] Replace MAX_NUMBER_OF_DYNAMIC_SESSION_RULES with two separate limits. r=robwu
|
||
Comment 4•1 month ago
|
||
| bugherder | ||
Change are ready for review:
- MDN New DNR properties #34214
- BCD DNR properties changes #23400
Description
•