Closed Bug 1899582 Opened 1 year ago Closed 1 year ago

Update styling for vertical tabs

Categories

(Firefox :: Sidebar, task)

task

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: sclements, Assigned: jsudiaman)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(2 files)

A combination of two small things:

  • The tab container indicators (colored underlines) should switch to the left side (the current treatment for the all tabs button in the horizontal tabstrip). See the spec.
  • Add a fade effect where the vertical tabs container meets the tools.

Something that came up in review in bug 1893655 is that we want to get rid of this style to show more of the title in the expanded state (this style gives it a fade effect). Per a comment from dao #tabbrowser-tabs:is(:not([closebuttons="activetab"]), [orient="vertical"]) would work in the expanded case but the unexpanded. Maybe for now just exclude both "allow showing more of the tab title" rules for vertical mode?"

Assignee: nobody → jsudiaman
Status: NEW → ASSIGNED

The tab container indicators (colored underlines) switch to the left side.
Add a fade effect where the vertical tabs container meets the tools.
Exclude both "allow showing more of the tab title" rules for vertical mode.

The tab container indicators (colored underlines) switch to the left side.
Add a fade effect where the vertical tabs container meets the tools.
Exclude both "allow showing more of the tab title" rules for vertical mode.

Pushed by jsudiaman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c0dc4150eb4 Update styling for vertical tabs r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,dao,sclements
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Regressions: 1909062
Regressions: 1947114
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: