1899856 - Running mach package-multi-locale for Android appears to not work as expected

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect, P3)

Description

[Olivia Hall [:olivia]]

While following these instructions, it sounds like the commands should work for GeckoView/Android. However, when running ./mach package-multi-locale --locales de it zh-TW
I get the following error:

 0:00.45 Processing chrome Gecko resources for locales ['de', 'it', 'zh-TW']
  Parallelism determined by memory: using 12 jobs for 12 cores based on 32.0 GiB RAM and estimated job size of 1.0 GiB
 0:00.45 /usr/bin/make -C /Users/olivia/Repos/gecko/obj-aarch64-unknown-linux-android -j12 -s chrome-de chrome-it chrome-zh-TW
 0:00.70 make[1]: warning: -jN forced in submake: disabling jobserver mode.
 0:00.70 make[1]: warning: -jN forced in submake: disabling jobserver mode.
 0:00.70 make[1]: warning: -jN forced in submake: disabling jobserver mode.
 0:00.72 Checking out /Users/olivia/.mozbuild/l10n-central/de
 0:00.72 Checking out /Users/olivia/.mozbuild/l10n-central/zh-TW
 0:00.73 Checking out /Users/olivia/.mozbuild/l10n-central/it
 0:00.75 Cloning into 'zh-TW'...
 0:00.75 Cloning into 'it'...
 0:00.75 Cloning into 'de'...
 0:04.78 error: git-remote-hg died of signal 11
 0:04.78 fatal: could not read ref refs/cinnabar/refs/heads/branches/default/tip
 0:04.78 make[2]: *** [merge-de] Error 128
 0:04.78 make[1]: *** [chrome-de] Error 2
 0:04.78 make: *** [chrome-de] Error 2
 0:04.78 make: *** Waiting for unfinished jobs....
 0:04.92 error: git-remote-hg died of signal 11
 0:04.92 fatal: could not read ref refs/cinnabar/refs/heads/branches/default/tip
 0:04.93 make[2]: *** [merge-zh-TW] Error 128
 0:04.93 make[1]: *** [chrome-zh-TW] Error 2
 0:04.93 make: *** [chrome-zh-TW] Error 2
 0:05.58 error: git-remote-hg died of signal 11
 0:05.58 fatal: could not read ref refs/cinnabar/refs/heads/branches/default/tip
 0:05.58 make[2]: *** [merge-it] Error 128
 0:05.58 make[1]: *** [chrome-it] Error 2
 0:05.58 make: *** [chrome-it] Error 2
Error running mach:

    mach package-multi-locale --locales de it zh-TW

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file package-multi-locale`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code 2: ['/usr/bin/make', '-C', '/Users/olivia/Repos/gecko/obj-aarch64-unknown-linux-android', '-j12', '-s', 'chrome-de', 'chrome-it', 'chrome-zh-TW']

  File "/Users/olivia/Repos/gecko/python/mozbuild/mozbuild/mach_commands.py", line 2874, in package_l10n
    command_context._run_make(
  File "/Users/olivia/Repos/gecko/python/mozbuild/mozbuild/base.py", line 810, in _run_make
    return fn(**params)
           ^^^^^^^^^^^^
  File "/Users/olivia/Repos/gecko/python/mozbuild/mozbuild/base.py", line 816, in _run_command_in_objdir
    return self.run_process(cwd=self.topobjdir, **args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/olivia/Repos/gecko/python/mach/mach/mixin/process.py", line 196, in run_process
    raise Exception(f"Process executed with non-0 exit code {status}: {args}")

Comment 1

[Nick Alexander :nalexander [he/him]]

Huh, that's not something I've tried or seen before.

:glandium -- how could we get more info from git-cinnabar?

:eemili -- maybe take a look at the GV jobs (like https://treeherder.mozilla.org/jobs?repo=mozilla-central&selectedTaskRun=DIjg4BuASA2lmjJXYhn9GA.0&revision=26de1dec88653ff0f29feff42d5c7e601c3fcdcc) to make sure they work with git in automation? Doubtless you've verified them since they're well known, but I did see you post about changes planned with the l10n monorepo project.

Comment 2

[Mike Hommey [:glandium]]

My first question would be what version of git-cinnabar is that?

Comment 3

[Mike Hommey [:glandium]]

And does running git clone hg::https://hg.mozilla.org/l10n-central/de reproduce it?

Comment 4

[Eemeli Aro [:eemeli]]

:bhearsum might have a better idea about the l10n git migration impact here.

Comment 5

[[e-mail] (:bhearsum)]

I don't have any insight into why this is happening, but it looks like this cloning happens in https://searchfox.org/mozilla-central/rev/dc08a7321a22918d5a26b7641f9b10cd2a09d98e/toolkit/locales/l10n.mk#151-159 via https://searchfox.org/mozilla-central/source/toolkit/locales/l10n.mk#174-179, and is local-developer code only, which means it shouldn't have an impact on our l10n -> github migration plans.

We're planning to stop using the hg repos in the next week anyways, so I suggest we not bother debugging this, and simply update this code post migration to pull from github.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to [e-mail] (:bhearsum) from comment #5)

I don't have any insight into why this is happening, but it looks like this cloning happens in https://searchfox.org/mozilla-central/rev/dc08a7321a22918d5a26b7641f9b10cd2a09d98e/toolkit/locales/l10n.mk#151-159 via https://searchfox.org/mozilla-central/source/toolkit/locales/l10n.mk#174-179, and is local-developer code only, which means it shouldn't have an impact on our l10n -> github migration plans.

Ah, of course -- I had forgotten about this local-developer oddity.

We're planning to stop using the hg repos in the next week anyways, so I suggest we not bother debugging this, and simply update this code post migration to pull from github.

That makes sense to me.

Comment 7

[Eemeli Aro [:eemeli]]

Olivia, could you check if this is still happening? I rather suspect that this may have been fixed by bug 1904586.

Note that you'll likely need to rm -rf ~/.mozbuild/l10n-central/ due to the repo structure change.

Comment 8

[Olivia Hall [:olivia]]

Thank you! It is working perfectly for me now. I tested by generating a German build of GeckoView Example and everything worked seamlessly.