1900047 - Crash [@ mozilla::net::nsHttpHandler::Init ] when clicking on notification in Windows notification center while TB is closed

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Francesco]

+++ This bug was initially created as a clone of Bug #1863798 +++

Steps to reproduce with Daily 2024-05-30:

1. Make sure you have both notifications and system notifications turned on.
2. Wait for a new mail.
3. Close TB.
4. Click on the notification in the Windows notification center.

Actual results:
TB starts and crashes.

Expected results:
Clicking on notification should open up Thunderbird and show the mail that we've been notified about.

bp-cff53266-761b-4953-999b-7e08c0240531
bp-c70f6b0f-08af-462d-905a-ce37f0240531
bp-3d9bd42c-8576-4285-b9d5-8113b0240531
bp-47a6ac2e-d053-46f7-93c5-e46700240531
bp-4bd29dbb-2b6d-4de4-8ca9-c11640240531

Comment 1

[Magnus Melin [:mkmelin]]

MOZ_CRASH Reason (Sanitized): MOZ_DIAGNOSTIC_ASSERT(false) (Try to init HttpHandler after shutdown)

Comment 2

[Wayne Mery (:wsmwk)]

#2 crash for Daily. Although the signature exists prior to 128.

Crash report: https://crash-stats.mozilla.org/report/index/cff53266-761b-4953-999b-7e08c0240531

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (Try to init HttpHandler after shutdown)

Top 10 frames:

0  xul.dll  mozilla::net::nsHttpHandler::Init()  netwerk/protocol/http/nsHttpHandler.cpp:323
1  xul.dll  mozilla::net::nsHttpHandler::GetInstance()  netwerk/protocol/http/nsHttpHandler.cpp:195
2  xul.dll  mozCreateComponent<mozilla::net::nsHttpHandler>()  netwerk/build/nsNetModule.cpp:64
3  xul.dll  mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsID const&, voi...  xpcom/components/StaticComponents.cpp:17534
4  xul.dll  (anonymous namespace)::EntryWrapper::CreateInstance(nsID const&, void**)  xpcom/components/nsComponentManager.cpp:189
4  xul.dll  nsComponentManagerImpl::GetServiceLocked(mozilla::Maybe<mozilla::detail::Base...  xpcom/components/nsComponentManager.cpp:987
5  xul.dll  nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**)  xpcom/components/nsComponentManager.cpp:1176
6  xul.dll  CallGetService(char const*, nsID const&, void**)  xpcom/components/nsComponentManagerUtils.cpp:63
6  xul.dll  nsGetServiceByContractID::operator()(nsID const&, void**) const  xpcom/components/nsComponentManagerUtils.cpp:240
7  xul.dll  nsCOMPtr<nsIProtocolHandler>::assign_from_gs_contractid(const nsGetServiceByC...  xpcom/base/nsCOMPtr.h:871

Comment 3

[Geoff Lankow (:darktrojan)]

I'm not sure how we're getting there, but the problem is that we're not doing anything to respond to a click on the notification if Thunderbird is closed. Not even attempting to open a window.

We also need to address the privacy issue of whether notifications (likely containing email or calendar content) should remain at all after Thunderbird closes. I'm not totally against it, but this late in the release cycle I think it would be best if all notifications got removed on shut-down. We can consider adding a preference later.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1900047 - Remove all Windows notifications when closing. r=aleca

... and handle clicks on notifications from a different session, even if they shouldn't happen.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a9a1f4abc686
Remove all Windows notifications when closing. r=aleca

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9406541 [details]
Bug 1900047 - Remove all Windows notifications when closing. r=aleca

[Approval Request Comment]
Regression caused by (bug #): bug 1863798
User impact if declined: notifications linger after TB closes, crash when clicked on
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 7

[Wayne Mery (:wsmwk)]

#1 crash for 128.0b1 and 128.0b2. Does appear to be gone in 129 nightly per crash-stats.

Comment 8

[Corey Bryant]

Comment on attachment 9406541 [details]
Bug 1900047 - Remove all Windows notifications when closing. r=aleca

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b4ff802046c2

Comment 10

[Wayne Mery (:wsmwk)]

v.fixed in 128.0b3 per crash-stats