1900127 - UX Fit-And-Finish Style Recommendations

Status: RESOLVED FIXED

(Firefox :: Translations, task, P3)

Description

[Erik Nordin [:nordzilla]]

Description

Dasha has given me some visual Fit-and-Finish changes to make for the panel before release.

---

Steps to implement

• Modify and clean up the CSS to better match the exact specifications given above.

---

Tests to implement

• These are visual changes only. Preexisting tests are sufficient coverage.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1900127 - Clean up SelectTranslations default states r=#translations-reviewers!,ohall

Removes the default focus outline when encountering error
states in the SelectTranslationsPanel, such as on the
try-again button. UX recommendation is that the button
is focused, but not outlined, unless the user tabbed to it.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1900127 - Clean up SelectTranslationsPanel markup r=#translations-reviewers!,ohall

Cleans up the state of the SelectTranslationsPanel markup
as part of the Fit-and-Finish UX review before release.

Depends on D212739

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1900127 - Clean up SelectTranslationsPanel margins r=#desktop-theme-reviewers!

Cleans up the SelectTranslationsPanel CSS to both
use spacing variables as well as more closely match
the margin spacing that is specified in the Figma.

Depends on D212740

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9828d6d4e8f6
Clean up SelectTranslations default states r=translations-reviewers,ohall
https://hg.mozilla.org/integration/autoland/rev/5de2382a319c
Clean up SelectTranslationsPanel markup r=translations-reviewers,ohall
https://hg.mozilla.org/integration/autoland/rev/b611dca1d8ac
Clean up SelectTranslationsPanel margins r=desktop-theme-reviewers,dao

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/9828d6d4e8f6
https://hg.mozilla.org/mozilla-central/rev/5de2382a319c
https://hg.mozilla.org/mozilla-central/rev/b611dca1d8ac