1902254 - The panel glitches when resized to the edge of the screen on Ubuntu22 + wayland window protocol

Status: VERIFIED FIXED

(Firefox :: Translations, defect, P2)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user triggers the Translations panel with a large paragraph, then grabs the resizer and enlarges the panel to the edge of the screen, he will notice that the panel glitches and the resizing process gets broken.

Found in

• Beta v128.0b2

Affected versions

• Nightly v129.0a1
• Beta v128.0b2

Tested platforms

• Affected platforms: Ubuntu 22 + wayland
• Unaffected platforms: Ubuntu22+X11, Windows10, MacOS11

Steps to reproduce

1. Launch the browser.
2. Maximize the window.
3. Ensure Select Translations feature is enabled
   browser.translations.select.enable = true
4. Load a webpage displayed in a different language than the browser
   https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal
5. Right-click, Select All
6. Right-click, Translate selection to English
7. Grab the resizer and drag it to the bottom of the screen.

Expected result

• The resizing works correctly, no glitching observed, resizing is blocked before the edge of the screen.

Actual result

• The panel glitches and the resizing process becomes broken.
• If the panel is opened in "flip mode", the panel glitches and moves up.

Regression range

• First bad: 2024-06-06
• Last good: 2024-06-05
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=28395944bc04fd540fa840398229ceb81befd6cd&tochange=b611dca1d8ac8ae082824cf0b31767c9d9ea3786
• Potentially regressed by: 1900127

Additional notes

• This issue is similar to bug 1894575 and bug 1894935, but it also happens on wayland after the changes in bug 1900127.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:nordzilla, since you are the author of the regressor, bug 1900127, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1902254 - Increase SelectTranslationsPanel resize buffer r=#translations-reviewers!,ohall

Increases the buffer kept between the bottom edge of the
panel and the bottom of the screen or window to be relative
to 1/5 of the panel's starting height upon open, rather than
an arbitrarily set 20 pixels.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dea9a93bec2b
Increase SelectTranslationsPanel resize buffer r=ohall,translations-reviewers

Comment 4

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/dea9a93bec2b

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nordzilla, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Erik Nordin [:nordzilla]]

Yes, I will be requesting uplift for this.

Comment 7

[Erik Nordin [:nordzilla]]

Attachment: Bug 1902254 - Increase SelectTranslationsPanel resize buffer

Increases the buffer kept between the bottom edge of the
panel and the bottom of the screen or window to be relative
to 1/5 of the panel's starting height upon open, rather than
an arbitrarily set 20 pixels.

Original Revision: https://phabricator.services.mozilla.com/D213589

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad9f94188763

Comment 9

[Daniel Bodea [:danibodea]]

This fix has been verified in Nightly v129.0a1 on Ubuntu 22 + wayland window protocol.
The glitch is not longer reproducing.
The fix will land in beta v128.0b5 and will be verified when available.

Comment 10

[Daniel Bodea [:danibodea]]

This fix has also been verified in Beta v128.0b5 in Ubuntu22 + wayland and a regression test was performed on Ubuntu22+X11 to make sure is works as intended. Thank you.