1901547 - Selected address book has solid icon color when creating new contact

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: image.png

STR:

• Open address book
• Create new contact
• Select address book to save contact in at the bottom

Actual result:
The icon for the currently selected item in the popup is entirely filled in with a solid color

Expected result:
The fill color should be lighter than the stroke color.

Regression range: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=09531f18debf98cd372cef108506220e3574bf02&tochange=bf8606e12ac652180c20083b9094cf0ee5e474d7

• so probably something in the m-c pushlog that modifies contextMenu or common-shared styles clashing with our icons in that menulist.

Comment 1

[Martin Giger [:freaktechnik]]

The corresponding m-c push would be https://hg.mozilla.org/mozilla-central/pushloghtml/?fromchange=0194887091045e366255fa0afc5be2bfbc68378f&tochange=4f7a5399c1ccd3d580631d65356e681ad7e28d74 - I haven't checked if we had a build for the earlier m-c push though.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1901547 - Set the fill property when the menuitem is checked/selected. r=#thunderbird-front-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/27e72ef1d05b
Set the fill property when the menuitem is checked/selected. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9407180 [details]
Bug 1901547 - Set the fill property when the menuitem is checked/selected. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
User impact if declined: unidentifiable icon in AB selector
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9407180 [details]
Bug 1901547 - Set the fill property when the menuitem is checked/selected. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 128.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a04fdc5256f5