1901926 - Tags mode is confused by tag with exclamation mark in it

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Geoff Lankow (:darktrojan)]

I'm surprised I've not noticed this before, because I usually have a tag named "pink!" in my test profile.

The smart mailboxes code will go looking for a folder at mailbox://nobody@smart%20mailboxes/tags/pink! but won't find it because the actual URL ends with pink%21. Then it will try to create the folder pink! and fail because it already exists. Folder names aren't converted to URLs using normal URL encoding, everything gets encoded except the alphanumeric characters. So we have to do that too when constructing URLs for the folder pane.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1901926 - Fix folder pane tag folders for tags with special characters. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe8f5d042ea0
Fix folder pane tag folders for tags with special characters. r=aleca

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9406899 [details]
Bug 1901926 - Fix folder pane tag folders for tags with special characters. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): never worked
User impact if declined: the tags folder mode misses tags with special characters
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 4

[Corey Bryant]

Comment on attachment 9406899 [details]
Bug 1901926 - Fix folder pane tag folders for tags with special characters. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Geoff, In the future I'd like to see all topics filled in for the approval request comment. I appreciate the tests you included in your commit! (Hopefully my exclamation point doesn't break anything here ;)

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/c4be0ca54d0d