1902255 - Number of messages still missing in group summary (dummy) headers

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect, P1)

Description

[Frank Winkler]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:127.0) Gecko/20100101 Firefox/127.0

Steps to reproduce:

When I sort my INBOX by date and also enable "Grouped by sort" ...

Actual results:

... TB versions before the UI redesign showed the number of messages in the time period "(#unread/#total)" in the separator line. Unfortunately, this has been removed in the new UI and I'm still missing it.

Expected results:

Please bring back this feature.

Comment 1

[Alessandro Castellani [:aleca]]

This is the exact same issue reported in bug 1901439, marking this as duplicate since it's newer.

Comment 2

[Francesco]

Attachment: 1902255.png

This bug is about the missing counts in the summary lines (dummy headers) which are missing from 128. Apparently regressed by bug 1883506. Bug 1901439 is about the "Total" column

Comment 3

[Alessandro Castellani [:aleca]]

Good catch, sorry for the confusion.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: Bug 1902255 - Re-enable the unread and total counter in the dummy row subject line. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c0675b7b7afb
Re-enable the unread and total counter in the dummy row subject line. r=babolivier

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9410275 [details]
Bug 1902255 - Re-enable the unread and total counter in the dummy row subject line. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1883506
User impact if declined: Missing count of unread and total messages in grouped by sort dummy row
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low and it also comes with a test

Comment 7

[Frank Winkler]

BTW: why has this feature been removed?

Comment 8

[Alessandro Castellani [:aleca]]

(In reply to Frank Winkler from comment #7)

BTW: why has this feature been removed?

It was a mistake from a clean up.
The old code generate the UI via C++, which it was wrong and we updated the code to offer the proper data for the front-end to handle it.
Unfortunately, we updated the UI only for the cards view, and since the table view didn't have any existing test to ensure this feature worked we missed it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29da802c2e5b
Follow-up: fix eslint errors. rs=lint DONTBUILD

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9410275 [details]
Bug 1902255 - Re-enable the unread and total counter in the dummy row subject line. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128 (did not go through beta 128 - needs to be tested on 128 ers)

Comment 11

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

I have provided an image comparing the affected build from 2024-06-13(20240613101205) and the ESR 128(20240703144221) with seemingly no differences when it comes to displaying messages while sorting by date and also enable "Grouped by sort". (tested on macOS 14)

Could you please guide me what exactly should be checked in order to properly verify this issue?

Screenshot URL

Comment 12

[Alessandro Castellani [:aleca]]

Steps to test and verify:

• Switch to table layout (this only affect the table view)
• Enable the "grouped by sort" option.
• Confirm that each grouped header comes with a (unread/total) counter tot he side of the subject.

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 128.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/5af51de20fd3
https://hg.mozilla.org/releases/comm-esr128/rev/cf643fd3b4f5

Comment 14

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Thank you Alessandro!

Managed to reproduce the faulty behaviour with the affected build from 2024-06-13(20240613101205) and the steps provided in comment 12.

Confirming this issue as verified fixed using macOS 14, Windows 11 and Ubuntu 22.04 with 128.0esr(20240709010607).