1902267 - [toolbar redesign] Download complete dialog is hidden by the refactored toolbar

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: DownloadCompleteUnactionable.mp4

Steps to reproduce

1. Have the new toolbar enabled and set to be shown on top (issue does not reproduce when the toolbar is at bottom)
2. Download a file (can use https://www.thinkbroadband.com/download for test downloads)
3. Check the "download complete" dialog

Expected behavior

The "download complete" dialog is shown fully and the user can easily interact with.

Actual behavior

The main action - the "Open" button of the "download complete" dialog is obstructed by the navigation bar.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1902267 - Ensure the download complete dialog is always above the bottom toolbar/navbar r=#android-reviewers

With this being controlled from just one place - the set behavior.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

With Bugzilla not wanting to ingest new attachments
I'll add here recording showing the impact of the proposed patch

• for the refactored toolbar - https://drive.google.com/file/d/1qjNnnNmQcjo5XE_IrA9A1W3fdjmM_n7d/view?usp=sharing
• for the "old" toolbar - https://drive.google.com/file/d/1lgrVZaSqHNTMIBRFLcm34pxYwI3bVF9X/view?usp=sharing

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c9a19e8af4e
Ensure the download complete dialog is always above the bottom toolbar/navbar r=android-reviewers,pollymce

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing lint failure

Backout link

Push with failures

Failure log

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Thanks and sorry for the troubles!
Updated now, locally the static analysis checks look good.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3262e8e0f3a4
Ensure the download complete dialog is always above the bottom toolbar/navbar r=android-reviewers,pollymce

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/3262e8e0f3a4

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Checked with Roger, users can't enable the new toolbar in beta -> don't need to uplift.
Updated the tracking flags.

Comment 10

[Delia Pop]

Attachment: Download_Dialogue.mp4

Verified as fixed on the latest Nightly 130.0a1 from 07/12 with Samsung Galaxy S22 Ultra (Android 14) and Samsung Tab S8 Ultra 5G (Android 14).
The download complete dialogue is no longer overlapped by the navigation bar.
However, I've noticed an instance where the dialogue will be appear mid-air when the navigation bar and address bar are hidden before the download is finished, and filed 1907566 for this issue.
Marking this ticket as verified.