1907566 - [Toolbar Redesign] Download complete dialog appears mid-air when the navigation bar and address bar are hidden

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Delia Pop]

Attachment: Download_Dialogue_HiddenNavAndressBars.mp4

Steps to reproduce

1. Open the latest Nightly 130.0a1 from 07/12.
2. Download a file (can use https://www.thinkbroadband.com/download for test downloads).
3. Scroll down on the page to hide the navigation bar and the address bar (if address bar position is set to Bottom) before the "Download completed" dialogue is displayed.
4. Observe the "Download completed" dialogue.

Expected behavior

The "Download completed" dialogue is displayed sticking to the navigation bar/the address bar (if address bar position is set to Bottom).

Actual behavior

The "Download complete" dialog is displayed mid-air when the navigation bar and address bar are hidden before the download is finished.
The dialogue will be correctly displayed when the navigation bar and address bar are displayed again, but only on Portrait mode on phone devices.

Device information

• Firefox version: Nightly 130.0a1 from 07/12
• Android device model: Samsung Galaxy S22 Ultra, any device
• Android OS version: Android 14

Additional information

The empty space remains displayed below the dialogue on tablet view/landscape mode on phone devices.
Note that this issue can not be reproduced on Beta and Release, where the toolbar will be displayed automatically when the "Download complete" dialog appears.

Comment 1

[Delia Pop]

Attachment: LandscapeMode.mp4

Comment 2

[Delia Pop]

Attachment: Download_Dialogue_HiddenNavAndressBar.png

Comment 3

[Chris Peterson [:cpeterson]]

Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

I see that when the addressbar is disabled
Whenever a "download complete" dialog appears the toolbar also gets shown.

This does not happen when using the navbar
So probably this is the "fix" that we need.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1907566 - Expand all browser toolbars when a download completes r=#android-reviewers

Up until now just the addressbar would be tried to be expanded
Now all toolbars shown will be expanded when a download completes and in that
ensure that the "download complete dialog" is properly anchored.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1907566 - Officialize BrowserToolbarView being a ScrollableToolbar r=#android-reviewers

It was already supporting most of the functionality.
Seems like this is a remainder of the work from bug 1873260.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b4bac641e7
Officialize BrowserToolbarView being a ScrollableToolbar  r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/443373b4e536
Expand all browser toolbars when a download completes r=android-reviewers,skhan

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/31b4bac641e7
https://hg.mozilla.org/mozilla-central/rev/443373b4e536

Comment 9

[Delia Pop]

Attachment: Download_BottomToolbar.mp4

This issue is partially fixed on the latest Nightly 131.0a1 from 08/09 with Xiaomi 12 Pro (Android 13), Google Pixel 8 Pro (Android 14) and OPPO A15s (Android 10).
The "Download completed" dialogue is now displayed sticking to the navigation bar/the address bar, but if the orientation is changed to Landscape/portrait mode:

• the empty space remains displayed below the dialogue in landscape mode;
• the dialogue is partially overlapped by the navigation bar in portrait mode;
  I'll file a separate ticket for this issue, and update this as verified.