[Toolbar Redesign] Download complete dialog is overlapped by navigation bar when changing the orientation from Landscape to Portrait
Categories
(Fenix :: Toolbar, defect)
Tracking
(firefox130 disabled, firefox131 disabled, firefox132 affected)
People
(Reporter: dpop, Assigned: petru)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Steps to reproduce
- Download a file (can use https://www.thinkbroadband.com/download for test downloads) while in Landscape mode.
- Once the "Download completed" dialogue is displayed, change the device orientation to Portrait mode.
- Observe the "Download completed" dialogue.
Expected behavior
The "Download completed" dialogue remains correctly displayed when changing the orientation.
Actual behavior
When changing the orientation from Landscape to Portrait, the "Download complete" dialog is partially cutoff by the navigation toolbar.
Device information
- Firefox version: Nightly 132.0a1 from 09/12
- Android device model/Android OS version: Samsung Galaxy A53 5G (Android 14), Xiaomi 12 Pro (Android 13), OPPO A15s (Android 10)
@Petru, can you take a look at this remaining issue from 1912473? Thanks!
|
Assignee | |
Comment 2•2 days ago
|
||
Can only reproduce with the navbar enabled and the toolbar at top.
Will look into fixing.
|
|
Assignee | |
Comment 3•2 days ago
|
||
Seems like it's intermittent <=> it depends on other toolbar updates and the overall timings for when these are executed.
|
|
Assignee | |
Comment 4•2 days ago
|
||
For each new download dialog to be shown we set a new DynamicDownloadDialogBehavior.
But a previous one may now be leaked because it continues to observe store updates and
reacting to when the orientation changes.
The leak is made possible because the "download complete dialog" is always attached to
the displayed layout, only it's visibility is updated depending on if it needs to be shown.
Description
•