1918416 - [Toolbar Redesign] Download complete dialog is overlapped by navigation bar when changing the orientation from Landscape to Portrait

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Delia Pop (Android QA)]

Attachment: Nightly132_0912_QA.mp4

Steps to reproduce

1. Download a file (can use https://www.thinkbroadband.com/download for test downloads) while in Landscape mode.
2. Once the "Download completed" dialogue is displayed, change the device orientation to Portrait mode.
3. Observe the "Download completed" dialogue.

Expected behavior

The "Download completed" dialogue remains correctly displayed when changing the orientation.

Actual behavior

When changing the orientation from Landscape to Portrait, the "Download complete" dialog is partially cutoff by the navigation toolbar.

Device information

• Firefox version: Nightly 132.0a1 from 09/12
• Android device model/Android OS version: Samsung Galaxy A53 5G (Android 14), Xiaomi 12 Pro (Android 13), OPPO A15s (Android 10)

Comment 1

[Delia Pop (Android QA)]

@Petru, can you take a look at this remaining issue from 1912473? Thanks!

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Can only reproduce with the navbar enabled and the toolbar at top.
Will look into fixing.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Seems like it's intermittent <=> it depends on other toolbar updates and the overall timings for when these are executed.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1918416 - part 1 - Prevent leaking DynamicDownloadDialogBehaviors r=#android-reviewers

For each new download dialog to be shown we set a new DynamicDownloadDialogBehavior.
But a previous one may now be leaked because it continues to observe store updates and
reacting to when the orientation changes.
The leak is made possible because the "download complete dialog" is always attached to
the displayed layout, only it's visibility is updated depending on if it needs to be shown.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1918416 - part 2 - Reposition the download dialog whenever the anchor height changes r=#android-reviewers

Replace repositioning when the app orientation change as this is not fully reliable.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84980f4e301e
part 1 - Prevent leaking DynamicDownloadDialogBehaviors r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/082fe7352b0f
part 2 - Reposition the download dialog whenever the anchor height changes r=android-reviewers,skhan

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/84980f4e301e
https://hg.mozilla.org/mozilla-central/rev/082fe7352b0f

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Planning to request uplift if QA confirms everything looks okay.
Keeping my NI until then.

Comment 10

[Delia Pop (Android QA)]

Attachment: Google Pixel 8 Pro_Nightly133.mp4

Verified as fixed in the latest Nightly 133.0a1 from 10/03 with Google Pixel 8 Pro (Android 14) and Samsung Galaxy S22 Ultra (Android 14). The "Download completed" dialogue remains correctly displayed when changing the orientation.
Tested with the following configurations:

• the old toolbar and the new toolbar redesign;
• Toolbar position Top and Bottom;
• "Scroll to hide toolbar" option enabled and disabled;

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9424996 [details]
Bug 1918416 - part 1 - Prevent leaking DynamicDownloadDialogBehaviors r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Visual issue - improper orientation of the download complete dialog after rotating the screen
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  • Download a file (can use https://www.thinkbroadband.com/download for test downloads) while in Landscape mode.
  • Once the "Download completed" dialogue is displayed, change the device orientation to Portrait mode.
  • Observe the "Download completed" dialogue.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targeted patch verified by QA in Nightly.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9424996 [details]
Bug 1918416 - part 1 - Prevent leaking DynamicDownloadDialogBehaviors r=#android-reviewers

Approved for 132.0b5.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/85cb5febb194
https://hg.mozilla.org/releases/mozilla-beta/rev/bcca6e859d5d

Comment 14

[Delia Pop (Android QA)]

This was verified as fixed in beta 132.0b5 with Lenovo Yoga Tab 11 (Android 12) and Samsung Galaxy S22 Ultra (Android 14).