1903090 - Incorrect "unread" icon for threaded replies

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot 2024-06-17 084339.png

When marking the parent message of a thread as "unread" also the "replies" button shows the unread icon even if no unread child messages are present.

Comment 1

[Alessandro Castellani [:aleca]]

This seems to be a problem coming from C++ properties which append the hasUnread property without distinguishing if the "child" message of a thread is the actual root message.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1903090 - Don't mark a message with hasUnread or hasNew if only the parent message is unread/new. r=#thunderbird-reviewers

Comment 3

[Geoff Lankow (:darktrojan)]

This already landed.
https://hg.mozilla.org/comm-central/rev/d1515c5b4fe985cd2e15d7cac8772f7b0c0ae5e3

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9408300 [details]
Bug 1903090 - Don't mark a message with hasUnread or hasNew if only the parent message is unread/new. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: small visual inconsistency showing both parent and child messages in a thread marked as unread/new even if they're not.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, and it also comes with automated tests

Comment 5

[Corey Bryant]

Comment on attachment 9408300 [details]
Bug 1903090 - Don't mark a message with hasUnread or hasNew if only the parent message is unread/new. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 128.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/96f8fedc4de6

Comment 7

[Ramona Gavrilescu]

Confirming this issue as verified fixed for 128.0b4(20240624182435) with Win 10&11 and macOS 14.

Comment 8

[Wayne Mery (:wsmwk)]

This was fixed on nightly first, so target milestone 129 was correct.
When confirming uplifts, you will want to use the flags, in this case "verified" for "thunderbird128"